mirror of
https://github.com/bitwarden/browser
synced 2025-12-20 10:13:31 +00:00
[PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript. - Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors - Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries) - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration. --- Co-authored-by: Vicki League <vleague@bitwarden.com>
This commit is contained in:
@@ -1,5 +1,3 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import { _isNumberValue } from "@angular/cdk/coercion";
|
||||
import { DataSource } from "@angular/cdk/collections";
|
||||
import { BehaviorSubject, combineLatest, map, Observable, Subscription } from "rxjs";
|
||||
@@ -19,7 +17,7 @@ export type FilterFn<T> = (data: T) => boolean;
|
||||
export class TableDataSource<T> extends DataSource<T> {
|
||||
private readonly _data: BehaviorSubject<T[]>;
|
||||
private readonly _sort: BehaviorSubject<Sort>;
|
||||
private readonly _filter = new BehaviorSubject<string | FilterFn<T>>(null);
|
||||
private readonly _filter = new BehaviorSubject<string | FilterFn<T>>(() => true);
|
||||
private readonly _renderData = new BehaviorSubject<T[]>([]);
|
||||
private _renderChangesSubscription: Subscription | null = null;
|
||||
|
||||
@@ -29,12 +27,12 @@ export class TableDataSource<T> extends DataSource<T> {
|
||||
* For example, a 'selectAll()' function would likely want to select the set of filtered data
|
||||
* shown to the user rather than all the data.
|
||||
*/
|
||||
filteredData: T[];
|
||||
filteredData?: T[];
|
||||
|
||||
constructor() {
|
||||
super();
|
||||
this._data = new BehaviorSubject([]);
|
||||
this._sort = new BehaviorSubject({ direction: "asc" });
|
||||
this._data = new BehaviorSubject([] as T[]);
|
||||
this._sort = new BehaviorSubject<Sort>({ direction: "asc" } as Sort);
|
||||
}
|
||||
|
||||
get data() {
|
||||
|
||||
Reference in New Issue
Block a user