mirror of
https://github.com/bitwarden/browser
synced 2025-12-16 08:13:42 +00:00
[PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript. - Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors - Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries) - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration. --- Co-authored-by: Vicki League <vleague@bitwarden.com>
This commit is contained in:
@@ -1,5 +1,3 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import {
|
||||
CdkVirtualScrollViewport,
|
||||
CdkFixedSizeVirtualScroll,
|
||||
@@ -9,7 +7,6 @@ import { CommonModule } from "@angular/common";
|
||||
import {
|
||||
AfterContentChecked,
|
||||
Component,
|
||||
ContentChild,
|
||||
OnDestroy,
|
||||
TemplateRef,
|
||||
Directive,
|
||||
@@ -18,6 +15,7 @@ import {
|
||||
ElementRef,
|
||||
TrackByFunction,
|
||||
input,
|
||||
contentChild,
|
||||
} from "@angular/core";
|
||||
|
||||
import { ScrollLayoutDirective } from "../layout";
|
||||
@@ -69,7 +67,7 @@ export class TableScrollComponent
|
||||
/** Optional trackBy function. */
|
||||
readonly trackBy = input<TrackByFunction<any> | undefined>();
|
||||
|
||||
@ContentChild(BitRowDef) protected rowDef: BitRowDef;
|
||||
protected readonly rowDef = contentChild(BitRowDef);
|
||||
|
||||
/**
|
||||
* Height of the thead element (in pixels).
|
||||
@@ -81,7 +79,7 @@ export class TableScrollComponent
|
||||
/**
|
||||
* Observer for table header, applies padding on resize.
|
||||
*/
|
||||
private headerObserver: ResizeObserver;
|
||||
private headerObserver?: ResizeObserver;
|
||||
|
||||
constructor(
|
||||
private zone: NgZone,
|
||||
|
||||
Reference in New Issue
Block a user