mirror of
https://github.com/bitwarden/browser
synced 2026-02-14 23:45:37 +00:00
[PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript. - Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors - Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries) - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration. --- Co-authored-by: Vicki League <vleague@bitwarden.com>
This commit is contained in:
@@ -1,15 +1,13 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import { isDataSource } from "@angular/cdk/collections";
|
||||
import { CommonModule } from "@angular/common";
|
||||
import {
|
||||
AfterContentChecked,
|
||||
Component,
|
||||
ContentChild,
|
||||
Directive,
|
||||
OnDestroy,
|
||||
TemplateRef,
|
||||
input,
|
||||
contentChild,
|
||||
} from "@angular/core";
|
||||
import { Observable } from "rxjs";
|
||||
|
||||
@@ -32,9 +30,9 @@ export class TableComponent implements OnDestroy, AfterContentChecked {
|
||||
readonly dataSource = input<TableDataSource<any>>();
|
||||
readonly layout = input<"auto" | "fixed">("auto");
|
||||
|
||||
@ContentChild(TableBodyDirective) templateVariable: TableBodyDirective;
|
||||
readonly templateVariable = contentChild(TableBodyDirective);
|
||||
|
||||
protected rows$: Observable<any[]>;
|
||||
protected rows$?: Observable<any[]>;
|
||||
|
||||
private _initialized = false;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user