mirror of
https://github.com/bitwarden/browser
synced 2025-12-16 00:03:56 +00:00
[PM-15847] libs/components strict migration (#15738)
This PR migrates `libs/components` to use strict TypeScript. - Remove `@ts-strict-ignore` from each file in `libs/components` and resolved any new compilation errors - Converted ViewChild and ContentChild decorators to use the new signal-based queries using the [Angular signal queries migration](https://angular.dev/reference/migrations/signal-queries) - Made view/content children `required` where appropriate, eliminating the need for additional null checking. This helped simplify the strict migration. --- Co-authored-by: Vicki League <vleague@bitwarden.com>
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { Component, OnInit, ViewChild } from "@angular/core";
|
||||
import { Component, OnInit, viewChild } from "@angular/core";
|
||||
import { ToastContainerDirective, ToastrService } from "ngx-toastr";
|
||||
|
||||
@Component({
|
||||
@@ -7,12 +7,11 @@ import { ToastContainerDirective, ToastrService } from "ngx-toastr";
|
||||
imports: [ToastContainerDirective],
|
||||
})
|
||||
export class ToastContainerComponent implements OnInit {
|
||||
@ViewChild(ToastContainerDirective, { static: true })
|
||||
toastContainer?: ToastContainerDirective;
|
||||
readonly toastContainer = viewChild(ToastContainerDirective);
|
||||
|
||||
constructor(private toastrService: ToastrService) {}
|
||||
|
||||
ngOnInit(): void {
|
||||
this.toastrService.overlayContainer = this.toastContainer;
|
||||
this.toastrService.overlayContainer = this.toastContainer();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,5 +1,3 @@
|
||||
// FIXME: Update this file to be type safe and remove this and next line
|
||||
// @ts-strict-ignore
|
||||
import { Injectable } from "@angular/core";
|
||||
import { IndividualConfig, ToastrService } from "ngx-toastr";
|
||||
|
||||
@@ -36,7 +34,7 @@ export class ToastService {
|
||||
: calculateToastTimeout(options.message),
|
||||
};
|
||||
|
||||
this.toastrService.show(null, options.title, toastrConfig);
|
||||
this.toastrService.show(undefined, options.title, toastrConfig);
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user