bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 09:13:33 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Add a fallback for image assets that do not load correctly

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-05-01 00:37:51 -05:00
parent 7994e6072a
commit 828e187dc4
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/autofill/overlay/content/autofill-overlay-inline-menu-elements.ts
View File

@@ -79,6 +79,8 @@ export class AutofillOverlayInlineMenuElements implements InlineMenuElementsInte
* longer triggers. * longer triggers.
*/ */
private removeInlineMenu = (message?: AutofillExtensionMessage) => { private removeInlineMenu = (message?: AutofillExtensionMessage) => {
return;
if (message?.overlayElement === AutofillOverlayElement.Button) { if (message?.overlayElement === AutofillOverlayElement.Button) {
this.removeInlineMenuButton(); this.removeInlineMenuButton();
return; return;

9
apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts
View File

@@ -397,6 +397,15 @@ class AutofillOverlayList extends AutofillOverlayPageElement {
try { try {
const url = new URL(cipher.icon.image); const url = new URL(cipher.icon.image);
cipherIcon.style.backgroundImage = `url(${url.href})`; cipherIcon.style.backgroundImage = `url(${url.href})`;
const dummyImageElement = globalThis.document.createElement("img");
dummyImageElement.src = url.href;
dummyImageElement.addEventListener("error", () => {
cipherIcon.style.backgroundImage = "";
cipherIcon.classList.add("cipher-icon", "bwi", cipher.icon.icon);
});
dummyImageElement.remove();
return cipherIcon; return cipherIcon;
} catch { } catch {
// Silently default to the globe icon element if the image URL is invalid // Silently default to the globe icon element if the image URL is invalid