bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-19 09:43:23 +00:00
Code Issues Releases Wiki Activity

Refactor: Move NudgesService to libs/angular/vault (#14843)

Browse Source 
* move NudgesService to libs/angular/vault to avoid circular dependencies

* remove fix for spotlight component in storybook
This commit is contained in:
Nick Krantz
2025-05-19 15:21:14 -05:00
committed by GitHub
parent ec27abfb81
commit 83c4438efe
19 changed files with 14 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libs/vault/src/cipher-form/cipher-form.stories.ts
View File

@@ -14,6 +14,7 @@ import { BehaviorSubject } from "rxjs";
import { CollectionView } from "@bitwarden/admin-console/common";
import { ViewCacheService } from "@bitwarden/angular/platform/view-cache";
import { NudgeStatus, NudgesService } from "@bitwarden/angular/vault";
import { AuditService } from "@bitwarden/common/abstractions/audit.service";
import { EventCollectionService } from "@bitwarden/common/abstractions/event/event-collection.service";
import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
@@ -34,9 +35,7 @@ import { AsyncActionsModule, ButtonModule, ItemModule, ToastService } from "@bit
import {
CipherFormConfig,
CipherFormGenerationService,
NudgeStatus,
PasswordRepromptService,
NudgesService,
} from "@bitwarden/vault";
// FIXME: remove `/apps` import from `/libs`
// FIXME: remove `src` and fix import

3
libs/vault/src/cipher-form/components/new-item-nudge/new-item-nudge.component.spec.ts
View File

@@ -3,13 +3,12 @@ import { ComponentFixture, TestBed } from "@angular/core/testing";
import { mock, MockProxy } from "jest-mock-extended";
import { of } from "rxjs";
import { NudgesService, NudgeType } from "@bitwarden/angular/vault";
import { AccountService, Account } from "@bitwarden/common/auth/abstractions/account.service";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import { UserId } from "@bitwarden/common/types/guid";
import { CipherType } from "@bitwarden/sdk-internal";
import { NudgesService, NudgeType } from "../../../services/nudges.service";
import { NewItemNudgeComponent } from "./new-item-nudge.component";
describe("NewItemNudgeComponent", () => {

2
libs/vault/src/cipher-form/components/new-item-nudge/new-item-nudge.component.ts
View File

@@ -2,6 +2,7 @@ import { NgIf } from "@angular/common";
import { Component, Input, OnInit } from "@angular/core";
import { firstValueFrom } from "rxjs";
import { NudgesService, NudgeType } from "@bitwarden/angular/vault";
import { AccountService } from "@bitwarden/common/auth/abstractions/account.service";
import { getUserId } from "@bitwarden/common/auth/services/account.service";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
@@ -9,7 +10,6 @@ import { UserId } from "@bitwarden/common/types/guid";
import { CipherType } from "@bitwarden/sdk-internal";
import { SpotlightComponent } from "../../../components/spotlight/spotlight.component";
import { NudgesService, NudgeType } from "../../../services/nudges.service";
@Component({
selector: "vault-new-item-nudge",