From 86a37cc75699d3fe7deefc582b18a21c19c32c61 Mon Sep 17 00:00:00 2001
From: Matt Gibson <mgibson@bitwarden.com>
Date: Wed, 4 Oct 2023 10:36:00 -0400
Subject: [PATCH] Avoid using `of` and `in` they're confusing.

This was also a bug here, because they're confusing.
---
 libs/common/src/vault/services/folder/folder.service.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libs/common/src/vault/services/folder/folder.service.ts b/libs/common/src/vault/services/folder/folder.service.ts
index c2522831d21..f7d05914bf8 100644
--- a/libs/common/src/vault/services/folder/folder.service.ts
+++ b/libs/common/src/vault/services/folder/folder.service.ts
@@ -30,6 +30,8 @@ export class FolderService implements InternalFolderServiceAbstraction {
     private activeUserStateProvider: ActiveUserStateProvider,
     private stateService: StateService
   ) {
+    (window as any).services ||= {};
+    (window as any).services.folderService = this;
     const derivedFoldersDefinition = FOLDERS.createDerivedDefinition(
       "memory",
       async (foldersMap) => {
@@ -118,9 +120,9 @@ export class FolderService implements InternalFolderServiceAbstraction {
   async delete(id: string | string[]): Promise<void> {
     const folderIds = typeof id === "string" ? [id] : id;
     await this.folderState.update((folders) => {
-      for (const folderId in folderIds) {
+      folderIds.forEach((folderId) => {
         delete folders[folderId];
-      }
+      });
     });
 
     // Items in a deleted folder are re-assigned to "No Folder"