From 87847dc8067462418acdb29f9b56bbe5444f5b12 Mon Sep 17 00:00:00 2001
From: Alec Rippberger <127791530+alec-livefront@users.noreply.github.com>
Date: Thu, 20 Mar 2025 15:23:19 -0500
Subject: [PATCH] fix: check device id and creationDate for falsey values

This commit adds validation to check for falsey values in device 'id' and 'creationDate' fields in the device management component. This prevents potential issues when these string values are empty or otherwise evaluate to false.

Resolves PM-18757
---
 .../app/auth/settings/security/device-management.component.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/web/src/app/auth/settings/security/device-management.component.ts b/apps/web/src/app/auth/settings/security/device-management.component.ts
index 0f31b8d4639..631ab02db7d 100644
--- a/apps/web/src/app/auth/settings/security/device-management.component.ts
+++ b/apps/web/src/app/auth/settings/security/device-management.component.ts
@@ -180,7 +180,7 @@ export class DeviceManagementComponent {
   private updateDeviceTable(devices: Array<DeviceView>): void {
     this.dataSource.data = devices
       .map((device: DeviceView): DeviceTableData | null => {
-        if (device.id == undefined) {
+        if (!device.id) {
           this.validationService.showError(new Error(this.i18nService.t("deviceIdMissing")));
           return null;
         }
@@ -190,7 +190,7 @@ export class DeviceManagementComponent {
           return null;
         }
 
-        if (device.creationDate == undefined) {
+        if (!device.creationDate) {
           this.validationService.showError(
             new Error(this.i18nService.t("deviceCreationDateMissing")),
           );