bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Fixing some typos

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-11 09:25:16 -05:00
parent 8bfa02eeea
commit 87cccdb52a
4 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/autofill/background/overlay.background.spec.ts
View File

@@ -1188,7 +1188,7 @@ describe("OverlayBackground", () => {
expect(tabsSendMessageSpy).toHaveBeenCalledWith( expect(tabsSendMessageSpy).toHaveBeenCalledWith(
sender.tab, sender.tab,
{ command: "checkIsAutofillInlineMenuButtonVisible" }, { command: "checkIsInlineMenuButtonVisible" },
{ frameId: 0 }, { frameId: 0 },
); );
}); });
@@ -1202,7 +1202,7 @@ describe("OverlayBackground", () => {
expect(tabsSendMessageSpy).toHaveBeenCalledWith( expect(tabsSendMessageSpy).toHaveBeenCalledWith(
sender.tab, sender.tab,
{ command: "checkIsAutofillInlineMenuListVisible" }, { command: "checkIsInlineMenuListVisible" },
{ frameId: 0 }, { frameId: 0 },
); );
}); });

13
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -85,9 +85,8 @@ export class OverlayBackground implements OverlayBackgroundInterface {
updateAutofillInlineMenuHidden: ({ message, sender }) => updateAutofillInlineMenuHidden: ({ message, sender }) =>
this.updateInlineMenuHidden(message, sender), this.updateInlineMenuHidden(message, sender),
checkIsAutofillInlineMenuButtonVisible: ({ sender }) => checkIsAutofillInlineMenuButtonVisible: ({ sender }) =>
this.checkIsAutofillInlineMenuButtonVisible(sender), this.checkIsInlineMenuButtonVisible(sender),
checkIsAutofillInlineMenuListVisible: ({ sender }) => checkIsAutofillInlineMenuListVisible: ({ sender }) => this.checkIsInlineMenuListVisible(sender),
this.checkIsAutofillInlineMenuListVisible(sender),
checkShouldRepositionInlineMenu: ({ sender }) => this.checkShouldRepositionInlineMenu(sender), checkShouldRepositionInlineMenu: ({ sender }) => this.checkShouldRepositionInlineMenu(sender),
getCurrentTabFrameId: ({ sender }) => this.getSenderFrameId(sender), getCurrentTabFrameId: ({ sender }) => this.getSenderFrameId(sender),
updateSubFrameData: ({ message, sender }) => this.updateSubFrameData(message, sender), updateSubFrameData: ({ message, sender }) => this.updateSubFrameData(message, sender),
@@ -984,12 +983,12 @@ export class OverlayBackground implements OverlayBackgroundInterface {
* *
* @param sender - The sender of the message * @param sender - The sender of the message
*/ */
private async checkIsAutofillInlineMenuButtonVisible( private async checkIsInlineMenuButtonVisible(
sender: chrome.runtime.MessageSender, sender: chrome.runtime.MessageSender,
): Promise<boolean> { ): Promise<boolean> {
return await BrowserApi.tabSendMessage( return await BrowserApi.tabSendMessage(
sender.tab, sender.tab,
{ command: "checkIsAutofillInlineMenuButtonVisible" }, { command: "checkIsInlineMenuButtonVisible" },
{ frameId: 0 }, { frameId: 0 },
); );
} }
@@ -999,12 +998,12 @@ export class OverlayBackground implements OverlayBackgroundInterface {
* *
* @param sender - The sender of the message * @param sender - The sender of the message
*/ */
private async checkIsAutofillInlineMenuListVisible( private async checkIsInlineMenuListVisible(
sender: chrome.runtime.MessageSender, sender: chrome.runtime.MessageSender,
): Promise<boolean> { ): Promise<boolean> {
return await BrowserApi.tabSendMessage( return await BrowserApi.tabSendMessage(
sender.tab, sender.tab,
{ command: "checkIsAutofillInlineMenuListVisible" }, { command: "checkIsInlineMenuListVisible" },
{ frameId: 0 }, { frameId: 0 },
); );
} }

4
apps/browser/src/autofill/overlay/inline-menu/abstractions/autofill-inline-menu-content.service.ts
View File

@@ -5,8 +5,8 @@ export type InlineMenuExtensionMessageHandlers = {
closeInlineMenu: ({ message }: AutofillExtensionMessageParam) => void; closeInlineMenu: ({ message }: AutofillExtensionMessageParam) => void;
appendInlineMenuElementsToDom: ({ message }: AutofillExtensionMessageParam) => Promise<void>; appendInlineMenuElementsToDom: ({ message }: AutofillExtensionMessageParam) => Promise<void>;
toggleInlineMenuHidden: ({ message }: AutofillExtensionMessageParam) => void; toggleInlineMenuHidden: ({ message }: AutofillExtensionMessageParam) => void;
checkIsAutofillInlineMenuButtonVisible: () => boolean; checkIsInlineMenuButtonVisible: () => boolean;
checkIsAutofillInlineMenuListVisible: () => boolean; checkIsInlineMenuListVisible: () => boolean;
}; };
export interface AutofillInlineMenuContentService { export interface AutofillInlineMenuContentService {

4
apps/browser/src/autofill/overlay/inline-menu/content/autofill-inline-menu-content.service.ts
View File

@@ -39,8 +39,8 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte
appendInlineMenuElementsToDom: ({ message }) => this.appendInlineMenuElements(message), appendInlineMenuElementsToDom: ({ message }) => this.appendInlineMenuElements(message),
toggleInlineMenuHidden: ({ message }) => toggleInlineMenuHidden: ({ message }) =>
this.toggleInlineMenuHidden(message.isInlineMenuHidden), this.toggleInlineMenuHidden(message.isInlineMenuHidden),
checkIsAutofillInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(), checkIsInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(),
checkIsAutofillInlineMenuListVisible: () => this.isInlineMenuListVisible(), checkIsInlineMenuListVisible: () => this.isInlineMenuListVisible(),
}; };
constructor() { constructor() {