From 8aa9f986f551f8efa362b678d83aea53c42c7a3f Mon Sep 17 00:00:00 2001
From: Jordan Aasen <166539328+jaasen-livefront@users.noreply.github.com>
Date: Tue, 9 Sep 2025 16:23:27 -0700
Subject: [PATCH] [PM-24935] - [Desktop] Fix loading state in cipher form save
 button (#16368)

* use bitButton for handling loading state

* remove unecessary code
---
 .../src/vault/app/vault/item-footer.component.html     | 10 +++-------
 .../src/vault/app/vault/item-footer.component.ts       |  1 -
 .../src/vault/app/vault/vault-v2.component.html        |  2 --
 apps/desktop/src/vault/app/vault/vault-v2.component.ts |  7 -------
 4 files changed, 3 insertions(+), 17 deletions(-)

diff --git a/apps/desktop/src/vault/app/vault/item-footer.component.html b/apps/desktop/src/vault/app/vault/item-footer.component.html
index c41bf254c8..162335d03b 100644
--- a/apps/desktop/src/vault/app/vault/item-footer.component.html
+++ b/apps/desktop/src/vault/app/vault/item-footer.component.html
@@ -4,16 +4,12 @@
       #submitBtn
       form="cipherForm"
       type="submit"
-      *ngIf="action !== 'view'"
+      [hidden]="action === 'view'"
+      bitButton
       class="primary"
       appA11yTitle="{{ 'save' | i18n }}"
     >
-      <span [hidden]="isSubmitting">{{ "save" | i18n }}</span>
-      <i
-        class="bwi bwi-spinner bwi-spin bwi-lg bwi-fw"
-        [hidden]="!isSubmitting"
-        aria-hidden="true"
-      ></i>
+      {{ "save" | i18n }}
     </button>
     <button
       type="button"
diff --git a/apps/desktop/src/vault/app/vault/item-footer.component.ts b/apps/desktop/src/vault/app/vault/item-footer.component.ts
index 18dcec1ac3..fef58d80a3 100644
--- a/apps/desktop/src/vault/app/vault/item-footer.component.ts
+++ b/apps/desktop/src/vault/app/vault/item-footer.component.ts
@@ -24,7 +24,6 @@ export class ItemFooterComponent implements OnInit {
   @Input({ required: true }) cipher: CipherView = new CipherView();
   @Input() collectionId: string | null = null;
   @Input({ required: true }) action: string = "view";
-  @Input() isSubmitting: boolean = false;
   @Input() masterPasswordAlreadyPrompted: boolean = false;
   @Output() onEdit = new EventEmitter<CipherView>();
   @Output() onClone = new EventEmitter<CipherView>();
diff --git a/apps/desktop/src/vault/app/vault/vault-v2.component.html b/apps/desktop/src/vault/app/vault/vault-v2.component.html
index 4a66abaf90..ef9fdbc2f8 100644
--- a/apps/desktop/src/vault/app/vault/vault-v2.component.html
+++ b/apps/desktop/src/vault/app/vault/vault-v2.component.html
@@ -19,7 +19,6 @@
       (onClone)="cloneCipher($event)"
       (onDelete)="deleteCipher()"
       (onCancel)="cancelCipher($event)"
-      [isSubmitting]="isSubmitting"
       [masterPasswordAlreadyPrompted]="cipherRepromptId === cipherId"
     ></app-vault-item-footer>
     <div class="content">
@@ -33,7 +32,6 @@
             formId="cipherForm"
             [config]="config"
             (cipherSaved)="savedCipher($event)"
-            [beforeSubmit]="onSubmit"
             [submitBtn]="footer?.submitBtn"
             (formStatusChange$)="formStatusChanged($event)"
           >
diff --git a/apps/desktop/src/vault/app/vault/vault-v2.component.ts b/apps/desktop/src/vault/app/vault/vault-v2.component.ts
index 256276cad8..13a8fa91bc 100644
--- a/apps/desktop/src/vault/app/vault/vault-v2.component.ts
+++ b/apps/desktop/src/vault/app/vault/vault-v2.component.ts
@@ -161,7 +161,6 @@ export class VaultV2Component<C extends CipherViewLike>
   cipher: CipherView | null = new CipherView();
   collections: CollectionView[] | null = null;
   config: CipherFormConfig | null = null;
-  isSubmitting = false;
 
   /** Tracks the disabled status of the edit cipher form */
   protected formDisabled: boolean = false;
@@ -741,7 +740,6 @@ export class VaultV2Component<C extends CipherViewLike>
     await this.vaultItemsComponent?.load(this.activeFilter.buildFilter()).catch(() => {});
     await this.go().catch(() => {});
     await this.vaultItemsComponent?.refresh().catch(() => {});
-    this.isSubmitting = false;
   }
 
   async deleteCipher() {
@@ -917,11 +915,6 @@ export class VaultV2Component<C extends CipherViewLike>
     });
   }
 
-  protected onSubmit = async () => {
-    this.isSubmitting = true;
-    return Promise.resolve(true);
-  };
-
   private prefillCipherFromFilter() {
     if (this.activeFilter.selectedCollectionId != null && this.vaultFilterComponent != null) {
       const collections = this.vaultFilterComponent.collections?.fullList.filter(