bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 16:53:34 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Refactoring implementation

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-05-02 17:20:36 -05:00
parent 7355e63d0c
commit 8ae427c60d
5 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/browser/src/autofill/background/overlay.background.spec.ts
View File

@@ -845,7 +845,7 @@ describe("OverlayBackground", () => {
}); });
}); });
describe("updateOverlayMenuHidden", () => { describe("updateInlineMenuHidden", () => {
beforeEach(async () => { beforeEach(async () => {
await initOverlayElementPorts(); await initOverlayElementPorts();
}); });
@@ -859,13 +859,13 @@ describe("OverlayBackground", () => {
sendMockExtensionMessage(message); sendMockExtensionMessage(message);
expect(buttonPortSpy.postMessage).toHaveBeenCalledWith({ expect(buttonPortSpy.postMessage).toHaveBeenCalledWith({
command: "updateOverlayMenuHidden", command: "updateInlineMenuHidden",
styles: { styles: {
display: "none", display: "none",
}, },
}); });
expect(listPortSpy.postMessage).toHaveBeenCalledWith({ expect(listPortSpy.postMessage).toHaveBeenCalledWith({
command: "updateOverlayMenuHidden", command: "updateInlineMenuHidden",
styles: { styles: {
display: "none", display: "none",
}, },
@@ -881,14 +881,14 @@ describe("OverlayBackground", () => {
sendMockExtensionMessage(message); sendMockExtensionMessage(message);
expect(buttonPortSpy.postMessage).toHaveBeenCalledWith({ expect(buttonPortSpy.postMessage).toHaveBeenCalledWith({
command: "updateOverlayMenuHidden", command: "updateInlineMenuHidden",
styles: { styles: {
display: "block", display: "block",
opacity: 0, opacity: 0,
}, },
}); });
expect(listPortSpy.postMessage).toHaveBeenCalledWith({ expect(listPortSpy.postMessage).toHaveBeenCalledWith({
command: "updateOverlayMenuHidden", command: "updateInlineMenuHidden",
styles: { styles: {
display: "block", display: "block",
opacity: 0, opacity: 0,

6
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -74,7 +74,7 @@ class OverlayBackground implements OverlayBackgroundInterface {
updateAutofillInlineMenuPosition: ({ message, sender }) => updateAutofillInlineMenuPosition: ({ message, sender }) =>
this.updateInlineMenuPosition(message, sender), this.updateInlineMenuPosition(message, sender),
updateAutofillInlineMenuHidden: ({ message, sender }) => updateAutofillInlineMenuHidden: ({ message, sender }) =>
this.updateOverlayMenuHidden(message, sender), this.updateInlineMenuHidden(message, sender),
updateFocusedFieldData: ({ message, sender }) => this.setFocusedFieldData(message, sender), updateFocusedFieldData: ({ message, sender }) => this.setFocusedFieldData(message, sender),
updateIsFieldCurrentlyFocused: ({ message }) => this.updateIsFieldCurrentlyFocused(message), updateIsFieldCurrentlyFocused: ({ message }) => this.updateIsFieldCurrentlyFocused(message),
checkIsFieldCurrentlyFocused: () => this.checkIsFieldCurrentlyFocused(), checkIsFieldCurrentlyFocused: () => this.checkIsFieldCurrentlyFocused(),
@@ -590,7 +590,7 @@ class OverlayBackground implements OverlayBackgroundInterface {
* @param display - The display property of the overlay, either "block" or "none" * @param display - The display property of the overlay, either "block" or "none"
* @param sender - The sender of the extension message * @param sender - The sender of the extension message
*/ */
private updateOverlayMenuHidden( private updateInlineMenuHidden(
{ isAutofillInlineMenuHidden, setTransparentOverlay }: OverlayBackgroundExtensionMessage, { isAutofillInlineMenuHidden, setTransparentOverlay }: OverlayBackgroundExtensionMessage,
sender: chrome.runtime.MessageSender, sender: chrome.runtime.MessageSender,
) { ) {
@@ -602,7 +602,7 @@ class OverlayBackground implements OverlayBackgroundInterface {
styles = { ...styles, opacity }; styles = { ...styles, opacity };
} }
const portMessage = { command: "updateOverlayMenuHidden", styles }; const portMessage = { command: "updateInlineMenuHidden", styles };
void BrowserApi.tabSendMessage( void BrowserApi.tabSendMessage(
sender.tab, sender.tab,

2
apps/browser/src/autofill/overlay/abstractions/autofill-overlay-iframe.service.ts
View File

@@ -19,7 +19,7 @@ type BackgroundPortMessageHandlers = {
initAutofillOverlayButton: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void; initAutofillOverlayButton: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void;
initAutofillOverlayList: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void; initAutofillOverlayList: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void;
updateIframePosition: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void; updateIframePosition: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void;
updateOverlayMenuHidden: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void; updateInlineMenuHidden: ({ message }: AutofillOverlayIframeExtensionMessageParam) => void;
updateOverlayPageColorScheme: () => void; updateOverlayPageColorScheme: () => void;
}; };

2
apps/browser/src/autofill/overlay/iframe-content/autofill-overlay-iframe.service.spec.ts
View File

@@ -395,7 +395,7 @@ describe("AutofillOverlayIframeService", () => {
it("updates the visibility of the iframe", () => { it("updates the visibility of the iframe", () => {
sendPortMessage(portSpy, { sendPortMessage(portSpy, {
command: "updateOverlayMenuHidden", command: "updateInlineMenuHidden",
styles: { display: "none" }, styles: { display: "none" },
}); });

2
apps/browser/src/autofill/overlay/iframe-content/autofill-overlay-iframe.service.ts
View File

@@ -45,7 +45,7 @@ class AutofillOverlayIframeService implements AutofillOverlayIframeServiceInterf
initAutofillOverlayButton: ({ message }) => this.initAutofillOverlay(message), initAutofillOverlayButton: ({ message }) => this.initAutofillOverlay(message),
initAutofillOverlayList: ({ message }) => this.initAutofillOverlay(message), initAutofillOverlayList: ({ message }) => this.initAutofillOverlay(message),
updateIframePosition: ({ message }) => this.updateIframePosition(message.styles), updateIframePosition: ({ message }) => this.updateIframePosition(message.styles),
updateOverlayMenuHidden: ({ message }) => this.updateElementStyles(this.iframe, message.styles), updateInlineMenuHidden: ({ message }) => this.updateElementStyles(this.iframe, message.styles),
updateOverlayPageColorScheme: () => this.updateOverlayPageColorScheme(), updateOverlayPageColorScheme: () => this.updateOverlayPageColorScheme(),
}; };