bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-03-02 03:21:19 +00:00
Code Issues Releases Wiki Activity

Add comment about usernames

Browse Source
This commit is contained in:
Anders Åberg
2025-10-13 15:21:33 -07:00
parent 50449cf8ae
commit 8d6dc009fe
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/desktop/desktop_native/objc/src/native/autofill/commands/sync.m
View File

@@ -24,7 +24,7 @@ void runSync(void* context, NSDictionary *params) {
NSString *uri = credential[@"uri"];
NSString *username = credential[@"username"];
// Skip credentials with null username
// Skip credentials with null username since MacOS crashes if we send credentials with empty usernames
if ([username isKindOfClass:[NSNull class]] || username.length == 0) {
NSLog(@"Skipping credential, username is empty: %@", credential);
continue;
@@ -42,8 +42,8 @@ void runSync(void* context, NSDictionary *params) {
NSString *cipherId = credential[@"cipherId"];
NSString *rpId = credential[@"rpId"];
NSString *userName = credential[@"userName"];
// Skip credentials with null userName
// Skip credentials with null username since MacOS crashes if we send credentials with empty usernames
if ([userName isKindOfClass:[NSNull class]] || userName.length == 0) {
NSLog(@"Skipping credential, username is empty: %@", credential);
continue;