bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 14:53:33 +00:00
Code Issues Releases Wiki Activity

[PM-14426] At-risk password carousel fixes (#13936)

Browse Source 
* [PM-19004] Add period to image alt text

* [PM-19298] Add data-testid for carousel confirmation button
This commit is contained in:
Shane Melton
2025-03-27 17:01:58 -07:00
committed by GitHub
parent cfafeaac66
commit 8dead9baf6
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
apps/browser/src/_locales/en/messages.json
View File

@@ -2534,15 +2534,15 @@
"message": "Your organization passwords are at-risk because they are weak, reused, and/or exposed.", "message": "Your organization passwords are at-risk because they are weak, reused, and/or exposed.",
"description": "Description of the review at-risk login slide on the at-risk password page carousel" "description": "Description of the review at-risk login slide on the at-risk password page carousel"
}, },
"reviewAtRiskLoginSlideImgAlt": { "reviewAtRiskLoginSlideImgAltPeriod": {
"message": "Illustration of a list of logins that are at-risk" "message": "Illustration of a list of logins that are at-risk."
}, },
"generatePasswordSlideDesc": { "generatePasswordSlideDesc": {
"message": "Quickly generate a strong, unique password with the Bitwarden autofill menu on the at-risk site.", "message": "Quickly generate a strong, unique password with the Bitwarden autofill menu on the at-risk site.",
"description": "Description of the generate password slide on the at-risk password page carousel" "description": "Description of the generate password slide on the at-risk password page carousel"
}, },
"generatePasswordSlideImgAlt": { "generatePasswordSlideImgAltPeriod": {
"message": "Illustration of the Bitwarden autofill menu displaying a generated password" "message": "Illustration of the Bitwarden autofill menu displaying a generated password."
}, },
"updateInBitwarden": { "updateInBitwarden": {
"message": "Update in Bitwarden" "message": "Update in Bitwarden"
@@ -2551,8 +2551,8 @@
"message": "Bitwarden will then prompt you to update the password in the password manager.", "message": "Bitwarden will then prompt you to update the password in the password manager.",
"description": "Description of the update in Bitwarden slide on the at-risk password page carousel" "description": "Description of the update in Bitwarden slide on the at-risk password page carousel"
}, },
"updateInBitwardenSlideImgAlt": { "updateInBitwardenSlideImgAltPeriod": {
"message": "Illustration of a Bitwarden’s notification prompting the user to update the login" "message": "Illustration of a Bitwarden’s notification prompting the user to update the login."
}, },
"turnOnAutofill": { "turnOnAutofill": {
"message": "Turn on autofill" "message": "Turn on autofill"

7
apps/browser/src/vault/popup/components/at-risk-carousel-dialog/at-risk-carousel-dialog.component.html
View File

@@ -6,7 +6,7 @@
class="tw-max-w-full tw-max-h-40" class="tw-max-w-full tw-max-h-40"
src="../../../../images/at-risk-password-carousel/review_at-risk_logins.light.png" src="../../../../images/at-risk-password-carousel/review_at-risk_logins.light.png"
appDarkImgSrc="../../../../images/at-risk-password-carousel/review_at-risk_logins.dark.png" appDarkImgSrc="../../../../images/at-risk-password-carousel/review_at-risk_logins.dark.png"
[alt]="'reviewAtRiskLoginSlideImgAlt' | i18n" [alt]="'reviewAtRiskLoginSlideImgAltPeriod' | i18n"
/> />
<h2 bitTypography="h2" class="tw-mt-8">{{ "reviewAtRiskLogins" | i18n }}</h2> <h2 bitTypography="h2" class="tw-mt-8">{{ "reviewAtRiskLogins" | i18n }}</h2>
<p bitTypography="body1"> <p bitTypography="body1">
@@ -18,7 +18,7 @@
class="tw-max-w-full tw-max-h-40" class="tw-max-w-full tw-max-h-40"
src="../../../../images/at-risk-password-carousel/generate_password.light.png" src="../../../../images/at-risk-password-carousel/generate_password.light.png"
appDarkImgSrc="../../../../images/at-risk-password-carousel/generate_password.dark.png" appDarkImgSrc="../../../../images/at-risk-password-carousel/generate_password.dark.png"
[alt]="'generatePasswordSlideImgAlt' | i18n" [alt]="'generatePasswordSlideImgAltPeriod' | i18n"
/> />
<h2 bitTypography="h2" class="tw-mt-8">{{ "generatePassword" | i18n }}</h2> <h2 bitTypography="h2" class="tw-mt-8">{{ "generatePassword" | i18n }}</h2>
<p bitTypography="body1"> <p bitTypography="body1">
@@ -30,7 +30,7 @@
class="tw-max-w-full tw-max-h-40" class="tw-max-w-full tw-max-h-40"
src="../../../../images/at-risk-password-carousel/update_login.light.png" src="../../../../images/at-risk-password-carousel/update_login.light.png"
appDarkImgSrc="../../../../images/at-risk-password-carousel/update_login.dark.png" appDarkImgSrc="../../../../images/at-risk-password-carousel/update_login.dark.png"
[alt]="'updateInBitwardenSlideImgAlt' | i18n" [alt]="'updateInBitwardenSlideImgAltPeriod' | i18n"
/> />
<h2 bitTypography="h2" class="tw-mt-8">{{ "updateInBitwarden" | i18n }}</h2> <h2 bitTypography="h2" class="tw-mt-8">{{ "updateInBitwarden" | i18n }}</h2>
<p bitTypography="body1"> <p bitTypography="body1">
@@ -47,6 +47,7 @@
block block
[disabled]="!dismissBtnEnabled()" [disabled]="!dismissBtnEnabled()"
(click)="dismiss()" (click)="dismiss()"
data-testid="confirm-carousel-button"
> >
{{ "reviewAtRiskPasswords" | i18n }} {{ "reviewAtRiskPasswords" | i18n }}
</button> </button>