From 8e33e0baf78d6ff69d0c08f9e842b8bcf1379b1c Mon Sep 17 00:00:00 2001
From: William Martin <contact@willmartian.com>
Date: Fri, 1 Sep 2023 12:30:30 -0400
Subject: [PATCH] format fingerprint in template

---
 .../src/background/nativeMessaging.background.ts       |  7 ++++---
 .../desktop-sync-verification-dialog.component.html    |  2 +-
 .../desktop-sync-verification-dialog.component.ts      |  2 +-
 .../browser-sync-verification-dialog.component.html    |  2 +-
 .../browser-sync-verification-dialog.component.ts      |  2 +-
 apps/desktop/src/services/native-messaging.service.ts  | 10 ++++------
 6 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/apps/browser/src/background/nativeMessaging.background.ts b/apps/browser/src/background/nativeMessaging.background.ts
index d393022b7b9..88fd81a3a70 100644
--- a/apps/browser/src/background/nativeMessaging.background.ts
+++ b/apps/browser/src/background/nativeMessaging.background.ts
@@ -422,9 +422,10 @@ export class NativeMessagingBackground {
   }
 
   private async showFingerprintDialog() {
-    const fingerprint = (
-      await this.cryptoService.getFingerprint(await this.stateService.getUserId(), this.publicKey)
-    ).join(" ");
+    const fingerprint = await this.cryptoService.getFingerprint(
+      await this.stateService.getUserId(),
+      this.publicKey
+    );
 
     this.messagingService.send("showNativeMessagingFinterprintDialog", {
       fingerprint: fingerprint,
diff --git a/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.html b/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.html
index d9bb0e33b2a..20cbd2890f0 100644
--- a/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.html
+++ b/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.html
@@ -5,7 +5,7 @@
   <span bitDialogContent>
     {{ "desktopIntegrationVerificationText" | i18n }}
     <br /><br />
-    <strong>{{ params.fingerprint }}</strong>
+    <strong>{{ params.fingerprint.join("-") }}</strong>
   </span>
   <ng-container bitDialogFooter>
     <button bitButton type="submit" buttonType="danger" bitDialogClose>
diff --git a/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.ts b/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.ts
index 78705e1ed57..c860ef1e342 100644
--- a/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.ts
+++ b/apps/browser/src/popup/components/desktop-sync-verification-dialog.component.ts
@@ -5,7 +5,7 @@ import { JslibModule } from "@bitwarden/angular/jslib.module";
 import { ButtonModule, DialogModule, DialogService } from "@bitwarden/components";
 
 export type DesktopSyncVerificationDialogParams = {
-  fingerprint: string;
+  fingerprint: string[];
 };
 
 @Component({
diff --git a/apps/desktop/src/app/components/browser-sync-verification-dialog.component.html b/apps/desktop/src/app/components/browser-sync-verification-dialog.component.html
index caf2d47698b..1efcccf3f84 100644
--- a/apps/desktop/src/app/components/browser-sync-verification-dialog.component.html
+++ b/apps/desktop/src/app/components/browser-sync-verification-dialog.component.html
@@ -5,7 +5,7 @@
   <span bitDialogContent>
     <p>{{ "verifyBrowserDesc" | i18n }}</p>
     <p>
-      <strong>{{ params.fingerprint }}</strong>
+      <strong>{{ params.fingerprint.join("-") }}</strong>
     </p>
   </span>
   <ng-container bitDialogFooter>
diff --git a/apps/desktop/src/app/components/browser-sync-verification-dialog.component.ts b/apps/desktop/src/app/components/browser-sync-verification-dialog.component.ts
index f627380860d..aefa5672a94 100644
--- a/apps/desktop/src/app/components/browser-sync-verification-dialog.component.ts
+++ b/apps/desktop/src/app/components/browser-sync-verification-dialog.component.ts
@@ -5,7 +5,7 @@ import { JslibModule } from "@bitwarden/angular/jslib.module";
 import { ButtonModule, DialogModule, DialogService } from "@bitwarden/components";
 
 export type BrowserSyncVerificationDialogParams = {
-  fingerprint: string;
+  fingerprint: string[];
 };
 
 @Component({
diff --git a/apps/desktop/src/services/native-messaging.service.ts b/apps/desktop/src/services/native-messaging.service.ts
index 646e7bcc508..7948daf502d 100644
--- a/apps/desktop/src/services/native-messaging.service.ts
+++ b/apps/desktop/src/services/native-messaging.service.ts
@@ -71,12 +71,10 @@ export class NativeMessagingService {
       if (await this.stateService.getEnableBrowserIntegrationFingerprint()) {
         ipcRenderer.send("nativeMessagingReply", { command: "verifyFingerprint", appId: appId });
 
-        const fingerprint = (
-          await this.cryptoService.getFingerprint(
-            await this.stateService.getUserId(),
-            remotePublicKey
-          )
-        ).join("-");
+        const fingerprint = await this.cryptoService.getFingerprint(
+          await this.stateService.getUserId(),
+          remotePublicKey
+        );
 
         this.messagingService.send("setFocus");