bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 14:23:32 +00:00
Code Issues Releases Wiki Activity

Fix Firefox phishing blocker continue button by awaiting tab navigation promises (#17436)

Browse Source
This commit is contained in:
Maximilian Power
2025-11-18 09:37:31 +01:00
committed by GitHub
parent 413a024e61
commit 8f04f25818
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/platform/browser/browser-api.ts
View File

@@ -268,11 +268,11 @@ export class BrowserApi {
static async closeTab(tabId: number): Promise<void> { static async closeTab(tabId: number): Promise<void> {
if (tabId) { if (tabId) {
if (BrowserApi.isWebExtensionsApi) { if (BrowserApi.isWebExtensionsApi) {
browser.tabs.remove(tabId).catch((error) => { await browser.tabs.remove(tabId).catch((error) => {
throw new Error("[BrowserApi] Failed to remove current tab: " + error.message); throw new Error("[BrowserApi] Failed to remove current tab: " + error.message);
}); });
} else if (BrowserApi.isChromeApi) { } else if (BrowserApi.isChromeApi) {
chrome.tabs.remove(tabId).catch((error) => { await chrome.tabs.remove(tabId).catch((error) => {
throw new Error("[BrowserApi] Failed to remove current tab: " + error.message); throw new Error("[BrowserApi] Failed to remove current tab: " + error.message);
}); });
} }
@@ -288,7 +288,7 @@ export class BrowserApi {
static async navigateTabToUrl(tabId: number, url: URL): Promise<void> { static async navigateTabToUrl(tabId: number, url: URL): Promise<void> {
if (tabId) { if (tabId) {
if (BrowserApi.isWebExtensionsApi) { if (BrowserApi.isWebExtensionsApi) {
browser.tabs.update(tabId, { url: url.href }).catch((error) => { await browser.tabs.update(tabId, { url: url.href }).catch((error) => {
throw new Error("Failed to navigate tab to URL: " + error.message); throw new Error("Failed to navigate tab to URL: " + error.message);
}); });
} else if (BrowserApi.isChromeApi) { } else if (BrowserApi.isChromeApi) {