bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

Bump node to 16 and npm (#575)

Browse Source 
* Bump engines required to node 16 and npm 8

* Bump @types/node to 16
The dep on node 14.18 will get cleaned up once we bump electron

* Modify build.yml to build with node 16 and npm 8

* Update requirements in README.md

* Remove install step for npm 8
npm v8.1.2 is included in node v16

* Rename install step

* Fixed typo
This commit is contained in:
Daniel James Smith
2021-12-13 11:43:10 +01:00
committed by GitHub
parent e9630eeae5
commit 8fc3cf50d2
10 changed files with 79 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/build.yml vendored
View File

@@ -33,11 +33,10 @@ jobs:
- name: Set up Node - name: Set up Node
uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea
with: with:
node-version: '14' node-version: '16'
- name: Update NPM - name: Install node-gyp
run: | run: |
npm install -g npm@7
npm install -g node-gyp npm install -g node-gyp
node-gyp install $(node -v) node-gyp install $(node -v)

4
README.md
View File

@@ -5,8 +5,8 @@
Common code referenced across Bitwarden JavaScript projects. Common code referenced across Bitwarden JavaScript projects.
## Requirements ## Requirements
* [Node.js](https://nodejs.org) v14.17 or greater * [Node.js](https://nodejs.org) v16.13.1 or greater
* NPM v7 * NPM v8
* Git * Git
* node-gyp * node-gyp

14
common/package-lock.json generated
View File

@@ -22,7 +22,7 @@
}, },
"devDependencies": { "devDependencies": {
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",
@@ -59,9 +59,9 @@
"dev": true "dev": true
}, },
"node_modules/@types/node": { "node_modules/@types/node": {
"version": "14.18.0", "version": "16.11.12",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ==", "integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true "dev": true
}, },
"node_modules/@types/node-forge": { "node_modules/@types/node-forge": {
@@ -547,9 +547,9 @@
"dev": true "dev": true
}, },
"@types/node": { "@types/node": {
"version": "14.18.0", "version": "16.11.12",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ==", "integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true "dev": true
}, },
"@types/node-forge": { "@types/node-forge": {

2
common/package.json
View File

@@ -21,7 +21,7 @@
}, },
"devDependencies": { "devDependencies": {
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",

33
electron/package-lock.json generated
View File

@@ -19,12 +19,13 @@
"keytar": "7.7.0" "keytar": "7.7.0"
}, },
"devDependencies": { "devDependencies": {
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"rimraf": "^3.0.2", "rimraf": "^3.0.2",
"typescript": "4.3.5" "typescript": "4.3.5"
} }
}, },
"../common": { "../common": {
"name": "@bitwarden/jslib-common",
"version": "0.0.0", "version": "0.0.0",
"license": "GPL-3.0", "license": "GPL-3.0",
"dependencies": { "dependencies": {
@@ -41,7 +42,7 @@
}, },
"devDependencies": { "devDependencies": {
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",
@@ -104,9 +105,10 @@
} }
}, },
"node_modules/@types/node": { "node_modules/@types/node": {
"version": "14.18.0", "version": "16.11.12",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ==" "integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true
}, },
"node_modules/@types/semver": { "node_modules/@types/semver": {
"version": "7.3.9", "version": "7.3.9",
@@ -638,6 +640,11 @@
"node": ">= 10.0.0" "node": ">= 10.0.0"
} }
}, },
"node_modules/electron/node_modules/@types/node": {
"version": "14.18.0",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ=="
},
"node_modules/encodeurl": { "node_modules/encodeurl": {
"version": "1.0.2", "version": "1.0.2",
"resolved": "https://registry.npmjs.org/encodeurl/-/encodeurl-1.0.2.tgz", "resolved": "https://registry.npmjs.org/encodeurl/-/encodeurl-1.0.2.tgz",
@@ -1887,7 +1894,7 @@
"@microsoft/signalr": "5.0.10", "@microsoft/signalr": "5.0.10",
"@microsoft/signalr-protocol-msgpack": "5.0.10", "@microsoft/signalr-protocol-msgpack": "5.0.10",
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",
@@ -1942,9 +1949,10 @@
} }
}, },
"@types/node": { "@types/node": {
"version": "14.18.0", "version": "16.11.12",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ==" "integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true
}, },
"@types/semver": { "@types/semver": {
"version": "7.3.9", "version": "7.3.9",
@@ -2275,6 +2283,13 @@
"@electron/get": "^1.0.1", "@electron/get": "^1.0.1",
"@types/node": "^14.6.2", "@types/node": "^14.6.2",
"extract-zip": "^1.0.3" "extract-zip": "^1.0.3"
},
"dependencies": {
"@types/node": {
"version": "14.18.0",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ=="
}
} }
}, },
"electron-log": { "electron-log": {

2
electron/package.json
View File

@@ -20,7 +20,7 @@
"lint:fix": "tslint 'src/**/*.ts' 'spec/**/*.ts' --fix" "lint:fix": "tslint 'src/**/*.ts' 'spec/**/*.ts' --fix"
}, },
"devDependencies": { "devDependencies": {
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"rimraf": "^3.0.2", "rimraf": "^3.0.2",
"typescript": "4.3.5" "typescript": "4.3.5"
}, },

16
node/package-lock.json generated
View File

@@ -21,7 +21,7 @@
"devDependencies": { "devDependencies": {
"@types/inquirer": "^7.3.1", "@types/inquirer": "^7.3.1",
"@types/lowdb": "^1.0.10", "@types/lowdb": "^1.0.10",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-fetch": "^2.5.10", "@types/node-fetch": "^2.5.10",
"rimraf": "^3.0.2", "rimraf": "^3.0.2",
"typescript": "4.3.5" "typescript": "4.3.5"
@@ -45,7 +45,7 @@
}, },
"devDependencies": { "devDependencies": {
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",
@@ -81,8 +81,9 @@
} }
}, },
"node_modules/@types/node": { "node_modules/@types/node": {
"version": "14.17.27", "version": "16.11.12",
"integrity": "sha512-94+Ahf9IcaDuJTle/2b+wzvjmutxXAEXU6O81JHblYXUg2BDG+dnBy7VxIPHKAyEEDHzCMQydTJuWvrE+Aanzw==", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true "dev": true
}, },
"node_modules/@types/node-fetch": { "node_modules/@types/node-fetch": {
@@ -693,7 +694,7 @@
"@microsoft/signalr": "5.0.10", "@microsoft/signalr": "5.0.10",
"@microsoft/signalr-protocol-msgpack": "5.0.10", "@microsoft/signalr-protocol-msgpack": "5.0.10",
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",
@@ -733,8 +734,9 @@
} }
}, },
"@types/node": { "@types/node": {
"version": "14.17.27", "version": "16.11.12",
"integrity": "sha512-94+Ahf9IcaDuJTle/2b+wzvjmutxXAEXU6O81JHblYXUg2BDG+dnBy7VxIPHKAyEEDHzCMQydTJuWvrE+Aanzw==", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true "dev": true
}, },
"@types/node-fetch": { "@types/node-fetch": {

2
node/package.json
View File

@@ -22,7 +22,7 @@
"devDependencies": { "devDependencies": {
"@types/inquirer": "^7.3.1", "@types/inquirer": "^7.3.1",
"@types/lowdb": "^1.0.10", "@types/lowdb": "^1.0.10",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-fetch": "^2.5.10", "@types/node-fetch": "^2.5.10",
"rimraf": "^3.0.2", "rimraf": "^3.0.2",
"typescript": "4.3.5" "typescript": "4.3.5"

44
package-lock.json generated
View File

@@ -17,7 +17,7 @@
"devDependencies": { "devDependencies": {
"@fluffy-spoon/substitute": "^1.202.0", "@fluffy-spoon/substitute": "^1.202.0",
"@types/jasmine": "^3.7.6", "@types/jasmine": "^3.7.6",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"concurrently": "^6.1.0", "concurrently": "^6.1.0",
"form-data": "4.0.0", "form-data": "4.0.0",
"jasmine": "^3.7.0", "jasmine": "^3.7.0",
@@ -45,8 +45,8 @@
"webpack": "^4.46.0" "webpack": "^4.46.0"
}, },
"engines": { "engines": {
"node": "~14", "node": "~16",
"npm": "~7" "npm": "~8"
} }
}, },
"angular": { "angular": {
@@ -93,7 +93,7 @@
}, },
"devDependencies": { "devDependencies": {
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",
@@ -117,7 +117,7 @@
"keytar": "7.7.0" "keytar": "7.7.0"
}, },
"devDependencies": { "devDependencies": {
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"rimraf": "^3.0.2", "rimraf": "^3.0.2",
"typescript": "4.3.5" "typescript": "4.3.5"
} }
@@ -139,7 +139,7 @@
"devDependencies": { "devDependencies": {
"@types/inquirer": "^7.3.1", "@types/inquirer": "^7.3.1",
"@types/lowdb": "^1.0.10", "@types/lowdb": "^1.0.10",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-fetch": "^2.5.10", "@types/node-fetch": "^2.5.10",
"rimraf": "^3.0.2", "rimraf": "^3.0.2",
"typescript": "4.3.5" "typescript": "4.3.5"
@@ -624,9 +624,10 @@
"dev": true "dev": true
}, },
"node_modules/@types/node": { "node_modules/@types/node": {
"version": "14.17.34", "version": "16.11.12",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.17.34.tgz", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-USUftMYpmuMzeWobskoPfzDi+vkpe0dvcOBRNOscFrGxVp4jomnRxWuVohgqBow2xyIPC0S3gjxV/5079jhmDg==" "integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true
}, },
"node_modules/@types/node-fetch": { "node_modules/@types/node-fetch": {
"version": "2.5.12", "version": "2.5.12",
@@ -2830,6 +2831,11 @@
"resolved": "https://registry.npmjs.org/yallist/-/yallist-4.0.0.tgz", "resolved": "https://registry.npmjs.org/yallist/-/yallist-4.0.0.tgz",
"integrity": "sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A==" "integrity": "sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A=="
}, },
"node_modules/electron/node_modules/@types/node": {
"version": "14.18.0",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ=="
},
"node_modules/elliptic": { "node_modules/elliptic": {
"version": "6.5.4", "version": "6.5.4",
"resolved": "https://registry.npmjs.org/elliptic/-/elliptic-6.5.4.tgz", "resolved": "https://registry.npmjs.org/elliptic/-/elliptic-6.5.4.tgz",
@@ -9698,7 +9704,7 @@
"@microsoft/signalr": "5.0.10", "@microsoft/signalr": "5.0.10",
"@microsoft/signalr-protocol-msgpack": "5.0.10", "@microsoft/signalr-protocol-msgpack": "5.0.10",
"@types/lunr": "^2.3.3", "@types/lunr": "^2.3.3",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-forge": "^0.9.7", "@types/node-forge": "^0.9.7",
"@types/papaparse": "^5.2.5", "@types/papaparse": "^5.2.5",
"@types/tldjs": "^2.3.0", "@types/tldjs": "^2.3.0",
@@ -9720,7 +9726,7 @@
"requires": { "requires": {
"@bitwarden/jslib-common": "file:../common", "@bitwarden/jslib-common": "file:../common",
"@nodert-win10-rs4/windows.security.credentials.ui": "^0.4.4", "@nodert-win10-rs4/windows.security.credentials.ui": "^0.4.4",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"electron": "14.2.0", "electron": "14.2.0",
"electron-log": "4.4.1", "electron-log": "4.4.1",
"electron-store": "8.0.1", "electron-store": "8.0.1",
@@ -9737,7 +9743,7 @@
"@bitwarden/jslib-common": "file:../common", "@bitwarden/jslib-common": "file:../common",
"@types/inquirer": "^7.3.1", "@types/inquirer": "^7.3.1",
"@types/lowdb": "^1.0.10", "@types/lowdb": "^1.0.10",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"@types/node-fetch": "^2.5.10", "@types/node-fetch": "^2.5.10",
"chalk": "^4.1.1", "chalk": "^4.1.1",
"commander": "7.2.0", "commander": "7.2.0",
@@ -9944,9 +9950,10 @@
"dev": true "dev": true
}, },
"@types/node": { "@types/node": {
"version": "14.17.34", "version": "16.11.12",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.17.34.tgz", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.12.tgz",
"integrity": "sha512-USUftMYpmuMzeWobskoPfzDi+vkpe0dvcOBRNOscFrGxVp4jomnRxWuVohgqBow2xyIPC0S3gjxV/5079jhmDg==" "integrity": "sha512-+2Iggwg7PxoO5Kyhvsq9VarmPbIelXP070HMImEpbtGCoyWNINQj4wzjbQCXzdHTRXnqufutJb5KAURZANNBAw==",
"dev": true
}, },
"@types/node-fetch": { "@types/node-fetch": {
"version": "2.5.12", "version": "2.5.12",
@@ -11703,6 +11710,13 @@
"@electron/get": "^1.0.1", "@electron/get": "^1.0.1",
"@types/node": "^14.6.2", "@types/node": "^14.6.2",
"extract-zip": "^1.0.3" "extract-zip": "^1.0.3"
},
"dependencies": {
"@types/node": {
"version": "14.18.0",
"resolved": "https://registry.npmjs.org/@types/node/-/node-14.18.0.tgz",
"integrity": "sha512-0GeIl2kmVMXEnx8tg1SlG6Gg8vkqirrW752KqolYo1PHevhhZN3bhJ67qHj+bQaINhX0Ra3TlWwRvMCd9iEfNQ=="
}
} }
}, },
"electron-log": { "electron-log": {

6
package.json
View File

@@ -26,7 +26,7 @@
"devDependencies": { "devDependencies": {
"@fluffy-spoon/substitute": "^1.202.0", "@fluffy-spoon/substitute": "^1.202.0",
"@types/jasmine": "^3.7.6", "@types/jasmine": "^3.7.6",
"@types/node": "^14.17.1", "@types/node": "^16.11.12",
"concurrently": "^6.1.0", "concurrently": "^6.1.0",
"form-data": "4.0.0", "form-data": "4.0.0",
"jasmine": "^3.7.0", "jasmine": "^3.7.0",
@@ -60,7 +60,7 @@
"@bitwarden/jslib-node": "file:node" "@bitwarden/jslib-node": "file:node"
}, },
"engines": { "engines": {
"node": "~14", "node": "~16",
"npm": "~7" "npm": "~8"
} }
} }