bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-06 10:33:57 +00:00
Code Issues Releases Wiki Activity

[PM-22090] Delete password on Windows desktop throws incorrect error (#15070)

Browse Source 
* delete password on Windows desktop throws incorrect error

* delete password on Windows desktop throws incorrect error

* napi documentation improvements

* napi documentation update

* better logging verbosity

* desktop native clippy errors

* unit test coverage

* napi TS documentation JS language friendly

* fixing merge conflicts
This commit is contained in:
Maciej Zieniuk
2025-06-30 12:38:51 +02:00
committed by GitHub
parent a05776c989
commit 8fec95671d
15 changed files with 407 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/desktop/src/platform/main/desktop-credential-storage-listener.ts
View File

@@ -35,13 +35,13 @@ export class DesktopCredentialStorageListener {
}
return val;
} catch (e) {
if (
e.message === "Password not found." ||
e.message === "The specified item could not be found in the keychain."
) {
if (e instanceof Error && e.message === passwords.PASSWORD_NOT_FOUND) {
if (message.action === "hasPassword") {
return false;
}
return null;
}
this.logService.info(e);
this.logService.error("[Credential Storage Listener] %s failed", message.action, e);
}
});
}