diff --git a/apps/web/src/app/vault/individual-vault/vault-filter/services/vault-filter.service.ts b/apps/web/src/app/vault/individual-vault/vault-filter/services/vault-filter.service.ts index 1f27773c467..0bd1265f4b1 100644 --- a/apps/web/src/app/vault/individual-vault/vault-filter/services/vault-filter.service.ts +++ b/apps/web/src/app/vault/individual-vault/vault-filter/services/vault-filter.service.ts @@ -294,9 +294,7 @@ export class VaultFilterService implements VaultFilterServiceAbstraction { // Otherwise, show only folders that have ciphers from the selected org and the "no folder" folder const orgCiphers = ciphers.filter((c) => c.organizationId == org?.id); - return storedFolders.filter( - (f) => orgCiphers.some((oc) => oc.folderId == f.id) || f.id == null, - ); + return storedFolders.filter((f) => orgCiphers.some((oc) => oc.folderId == f.id) || !f.id); } protected buildFolderTree(folders?: FolderView[]): TreeNode { diff --git a/apps/web/src/app/vault/individual-vault/vault-filter/shared/models/routed-vault-filter-bridge.model.ts b/apps/web/src/app/vault/individual-vault/vault-filter/shared/models/routed-vault-filter-bridge.model.ts index f9a80791030..96e42e1a450 100644 --- a/apps/web/src/app/vault/individual-vault/vault-filter/shared/models/routed-vault-filter-bridge.model.ts +++ b/apps/web/src/app/vault/individual-vault/vault-filter/shared/models/routed-vault-filter-bridge.model.ts @@ -87,7 +87,7 @@ export class RoutedVaultFilterBridge implements VaultFilter { return this.legacyFilter.selectedFolderNode; } set selectedFolderNode(value: TreeNode) { - const folderId = value != null && value.node.id === null ? Unassigned : value?.node.id; + const folderId = value?.node.id ?? Unassigned; this.bridgeService.navigate({ ...this.routedFilter, folderId, diff --git a/libs/angular/src/vault/vault-filter/services/vault-filter.service.ts b/libs/angular/src/vault/vault-filter/services/vault-filter.service.ts index 9bc10e5ffc5..6fc0340e32d 100644 --- a/libs/angular/src/vault/vault-filter/services/vault-filter.service.ts +++ b/libs/angular/src/vault/vault-filter/services/vault-filter.service.ts @@ -86,7 +86,7 @@ export class VaultFilterService implements DeprecatedVaultFilterServiceAbstracti const ciphers = await this.cipherService.getAllDecrypted(userId); const orgCiphers = ciphers.filter((c) => c.organizationId == organizationId); folders = storedFolders.filter( - (f) => orgCiphers.some((oc) => oc.folderId == f.id) || f.id == null, + (f) => orgCiphers.some((oc) => oc.folderId == f.id) || !f.id, ); } diff --git a/libs/common/src/vault/models/view/folder.view.ts b/libs/common/src/vault/models/view/folder.view.ts index ead32c4a322..6052ae9df37 100644 --- a/libs/common/src/vault/models/view/folder.view.ts +++ b/libs/common/src/vault/models/view/folder.view.ts @@ -16,7 +16,6 @@ export class FolderView implements View, ITreeNodeObject { } this.id = f.id; - this.name = f.name.toString(); this.revisionDate = f.revisionDate; } diff --git a/libs/importer/src/components/import.component.ts b/libs/importer/src/components/import.component.ts index 0ff62b00e78..83a18d35dc6 100644 --- a/libs/importer/src/components/import.component.ts +++ b/libs/importer/src/components/import.component.ts @@ -354,7 +354,7 @@ export class ImportComponent implements OnInit, OnDestroy, AfterViewInit { switchMap((userId) => { return this.folderService.folderViews$(userId); }), - map((folders) => folders.filter((f) => f.id != null)), + map((folders) => folders.filter((f) => !!f.id)), ); this.formGroup.controls.targetSelector.disable(); diff --git a/libs/importer/src/importers/base-importer.ts b/libs/importer/src/importers/base-importer.ts index f8acb5e0643..cbf6864f7d7 100644 --- a/libs/importer/src/importers/base-importer.ts +++ b/libs/importer/src/importers/base-importer.ts @@ -4,12 +4,12 @@ import * as papa from "papaparse"; // This import has been flagged as unallowed for this class. It may be involved in a circular dependency loop. // eslint-disable-next-line no-restricted-imports -import { Collection, CollectionView } from "@bitwarden/admin-console/common"; +import { CollectionView } from "@bitwarden/admin-console/common"; import { normalizeExpiryYearFormat } from "@bitwarden/common/autofill/utils"; import { LogService } from "@bitwarden/common/platform/abstractions/log.service"; import { Utils } from "@bitwarden/common/platform/misc/utils"; import { ConsoleLogService } from "@bitwarden/common/platform/services/console-log.service"; -import { OrganizationId } from "@bitwarden/common/types/guid"; +import { CollectionId, OrganizationId } from "@bitwarden/common/types/guid"; import { FieldType, SecureNoteType, CipherType } from "@bitwarden/common/vault/enums"; import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view"; import { FieldView } from "@bitwarden/common/vault/models/view/field.view"; @@ -279,8 +279,7 @@ export abstract class BaseImporter { const collection = new CollectionView({ name: f.name, organizationId: this.organizationId, - // FIXME: Folder.id may be null, this should be changed when refactoring Folders to be ts-strict - id: Collection.isCollectionId(f.id) ? f.id : null, + id: f.id as CollectionId, }); return collection; }); diff --git a/libs/tools/export/vault-export/vault-export-core/src/services/individual-vault-export.service.ts b/libs/tools/export/vault-export/vault-export-core/src/services/individual-vault-export.service.ts index e7a97801e09..91e1908b78c 100644 --- a/libs/tools/export/vault-export/vault-export-core/src/services/individual-vault-export.service.ts +++ b/libs/tools/export/vault-export/vault-export-core/src/services/individual-vault-export.service.ts @@ -240,7 +240,7 @@ export class IndividualVaultExportService }; folders.forEach((f) => { - if (f.id == null) { + if (!f.id) { return; } const folder = new FolderWithIdExport(); @@ -268,7 +268,7 @@ export class IndividualVaultExportService private buildCsvExport(decFolders: FolderView[], decCiphers: CipherView[]): string { const foldersMap = new Map(); decFolders.forEach((f) => { - if (f.id != null) { + if (!f.id) { foldersMap.set(f.id, f); } }); @@ -302,7 +302,7 @@ export class IndividualVaultExportService }; decFolders.forEach((f) => { - if (f.id == null) { + if (!f.id) { return; } const folder = new FolderWithIdExport();