bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Code Issues Releases Wiki Activity

Remove unnecessary complex types (#7451)

Browse Source 
#7290 introduced these types, but during development we switched over to specifying dependencies in type parameters instead of an object. This change meant we no longer needed these `Type` or `ShapeToInstance` types, greatly simplifying the types related to derived state.
This commit is contained in:
Matt Gibson
2024-01-04 16:50:55 -05:00
committed by GitHub
parent 5e11cb212d
commit 92f593df08
14 changed files with 31 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/common/spec/fake-state-provider.ts
View File

@@ -14,7 +14,7 @@ import {
DerivedStateProvider,
} from "../src/platform/state";
import { UserId } from "../src/types/guid";
import { ShapeToInstances, DerivedStateDependencies } from "../src/types/state";
import { DerivedStateDependencies } from "../src/types/state";
import {
FakeActiveUserState,
@@ -92,7 +92,7 @@ export class FakeStateProvider implements StateProvider {
getDerived<TFrom, TTo, TDeps extends DerivedStateDependencies>(
parentState$: Observable<TFrom>,
deriveDefinition: DeriveDefinition<unknown, TTo, TDeps>,
dependencies: ShapeToInstances<TDeps>,
dependencies: TDeps,
): DerivedState<TTo> {
return this.derived.get(parentState$, deriveDefinition, dependencies);
}
@@ -108,7 +108,7 @@ export class FakeDerivedStateProvider implements DerivedStateProvider {
get<TFrom, TTo, TDeps extends DerivedStateDependencies>(
parentState$: Observable<TFrom>,
deriveDefinition: DeriveDefinition<TFrom, TTo, TDeps>,
dependencies: ShapeToInstances<TDeps>,
dependencies: TDeps,
): DerivedState<TTo> {
let result = this.states.get(deriveDefinition.buildCacheKey()) as DerivedState<TTo>;