bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-21 10:43:35 +00:00
Code Issues Releases Wiki Activity

Remove unnecessary complex types (#7451)

Browse Source 
#7290 introduced these types, but during development we switched over to specifying dependencies in type parameters instead of an object. This change meant we no longer needed these `Type` or `ShapeToInstance` types, greatly simplifying the types related to derived state.
This commit is contained in:
Matt Gibson
2024-01-04 16:50:55 -05:00
committed by GitHub
parent 5e11cb212d
commit 92f593df08
14 changed files with 31 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/common/src/platform/state/derived-state.provider.ts
View File

@@ -1,6 +1,6 @@
import { Observable } from "rxjs";
import { ShapeToInstances, DerivedStateDependencies } from "../../types/state";
import { DerivedStateDependencies } from "../../types/state";
import { DeriveDefinition } from "./derive-definition";
import { DerivedState } from "./derived-state";
@@ -20,6 +20,6 @@ export abstract class DerivedStateProvider {
get: <TFrom, TTo, TDeps extends DerivedStateDependencies>(
parentState$: Observable<TFrom>,
deriveDefinition: DeriveDefinition<TFrom, TTo, TDeps>,
dependencies: ShapeToInstances<TDeps>,
dependencies: TDeps,
) => DerivedState<TTo>;
}