[PM-28817] - update copy for vault premium spotlight (#17667)

* update copy for vault premium spotlight

* remove unecessary observable

* fix logic

apps/browser/src/_locales/en/messages.json

@@ -5821,11 +5821,11 @@
   "upgradeToPremium": {
     "message": "Upgrade to Premium"
   },
-  "upgradeCompleteSecurity": {
-    "message": "Upgrade for complete security"
+  "unlockAdvancedSecurity": {
+    "message": "Unlock advanced security features"
   },
-  "premiumGivesMoreTools": {
-    "message": "Premium gives you more tools to stay secure, work efficiently, and stay in control."
+  "unlockAdvancedSecurityDesc": {
+    "message": "A Premium subscription gives you more tools to stay secure and in control"
   },
   "explorePremium": {
     "message": "Explore Premium"

apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.html

@@ -44,8 +44,8 @@
   <ng-container slot="above-scroll-area">
     <ng-container *ngIf="showPremiumSpotlight$ | async">
       <bit-spotlight
-        [title]="'upgradeCompleteSecurity' | i18n"
-        [subtitle]="'premiumGivesMoreTools' | i18n"
+        [title]="'unlockAdvancedSecurity' | i18n"
+        [subtitle]="'unlockAdvancedSecurityDesc' | i18n"
         [buttonText]="'explorePremium' | i18n"
         (onButtonClick)="showPremiumDialog()"
         (onDismiss)="dismissVaultNudgeSpotlight(NudgeType.PremiumUpgrade)"

apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.ts

@@ -165,15 +165,14 @@ export class VaultV2Component implements OnInit, AfterViewInit, OnDestroy {
 
   protected showPremiumSpotlight$ = combineLatest([
     this.showPremiumNudgeSpotlight$,
-    this.showEmptyVaultSpotlight$,
     this.showHasItemsVaultSpotlight$,
     this.hasPremium$,
     this.cipherCount$,
     this.accountAgeInDays$,
   ]).pipe(
     map(
-      ([showNudge, emptyVault, hasItems, hasPremium, count, age]) =>
-        showNudge && !emptyVault && !hasItems && !hasPremium && count >= 5 && age >= 7,
+      ([showPremiumNudge, showHasItemsNudge, hasPremium, count, age]) =>
+        showPremiumNudge && !showHasItemsNudge && !hasPremium && count >= 5 && age >= 7,
     ),
     shareReplay({ bufferSize: 1, refCount: true }),
   );