From 963e339e4f55fbe407ab419f9a948765bc73491e Mon Sep 17 00:00:00 2001
From: Jason Ng <jng@bitwarden.com>
Date: Fri, 30 Aug 2024 15:38:37 -0400
Subject: [PATCH] PM-11429 Users with Except PW permissions will not get Copy
 Password Option Vault V2 (#10831)

---
 .../item-copy-action/item-copy-actions.component.html     | 8 +++++++-
 libs/vault/src/services/copy-cipher-field.service.spec.ts | 6 ------
 libs/vault/src/services/copy-cipher-field.service.ts      | 2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/apps/browser/src/vault/popup/components/vault-v2/item-copy-action/item-copy-actions.component.html b/apps/browser/src/vault/popup/components/vault-v2/item-copy-action/item-copy-actions.component.html
index 487168539b9..f4444a10aeb 100644
--- a/apps/browser/src/vault/popup/components/vault-v2/item-copy-action/item-copy-actions.component.html
+++ b/apps/browser/src/vault/popup/components/vault-v2/item-copy-action/item-copy-actions.component.html
@@ -13,7 +13,13 @@
     <button type="button" bitMenuItem appCopyField="username" [cipher]="cipher">
       {{ "copyUsername" | i18n }}
     </button>
-    <button type="button" bitMenuItem appCopyField="password" [cipher]="cipher">
+    <button
+      *ngIf="cipher.viewPassword"
+      type="button"
+      bitMenuItem
+      appCopyField="password"
+      [cipher]="cipher"
+    >
       {{ "copyPassword" | i18n }}
     </button>
     <button type="button" bitMenuItem appCopyField="totp" [cipher]="cipher">
diff --git a/libs/vault/src/services/copy-cipher-field.service.spec.ts b/libs/vault/src/services/copy-cipher-field.service.spec.ts
index 57c77ebb0bd..4f28ddd0089 100644
--- a/libs/vault/src/services/copy-cipher-field.service.spec.ts
+++ b/libs/vault/src/services/copy-cipher-field.service.spec.ts
@@ -62,12 +62,6 @@ describe("CopyCipherFieldService", () => {
       expect(platformUtilsService.copyToClipboard).not.toHaveBeenCalled();
     });
 
-    it("should return early when cipher.viewPassword is false", async () => {
-      cipher.viewPassword = false;
-      await service.copy(valueToCopy, actionType, cipher, skipReprompt);
-      expect(platformUtilsService.copyToClipboard).not.toHaveBeenCalled();
-    });
-
     it("should copy value to clipboard", async () => {
       await service.copy(valueToCopy, actionType, cipher, skipReprompt);
       expect(platformUtilsService.copyToClipboard).toHaveBeenCalledWith(valueToCopy);
diff --git a/libs/vault/src/services/copy-cipher-field.service.ts b/libs/vault/src/services/copy-cipher-field.service.ts
index 372409b8e97..82a9542feb2 100644
--- a/libs/vault/src/services/copy-cipher-field.service.ts
+++ b/libs/vault/src/services/copy-cipher-field.service.ts
@@ -106,7 +106,7 @@ export class CopyCipherFieldService {
       return;
     }
 
-    if (valueToCopy == null || !cipher.viewPassword) {
+    if (valueToCopy == null) {
       return;
     }