Require lifetime specification of user-scoped data (#8669)

* Require lifetime specification of user-scoped data

* Decouple tests for different classes

This coupling assumed constant interfaces with classes that isn't a guarantee and requires significant acrobatics to make types work, now that key definitions are not a consistent base.

* Fix types

libs/common/src/platform/state/implementations/default-state.provider.spec.ts

@@ -17,6 +17,7 @@ import { UserId } from "../../../types/guid";
 import { DeriveDefinition } from "../derive-definition";
 import { KeyDefinition } from "../key-definition";
 import { StateDefinition } from "../state-definition";
+import { UserKeyDefinition } from "../user-key-definition";
 
 import { DefaultStateProvider } from "./default-state.provider";
 
@@ -52,12 +53,12 @@ describe("DefaultStateProvider", () => {
   describe.each([
     [
       "getUserState$",
-      (keyDefinition: KeyDefinition<string>, userId?: UserId) =>
+      (keyDefinition: UserKeyDefinition<string>, userId?: UserId) =>
         sut.getUserState$(keyDefinition, userId),
     ],
     [
       "getUserStateOrDefault$",
-      (keyDefinition: KeyDefinition<string>, userId?: UserId) =>
+      (keyDefinition: UserKeyDefinition<string>, userId?: UserId) =>
         sut.getUserStateOrDefault$(keyDefinition, { userId: userId }),
     ],
   ])(
@@ -65,7 +66,7 @@ describe("DefaultStateProvider", () => {
     (
       _testName: string,
       methodUnderTest: (
-        keyDefinition: KeyDefinition<string>,
+        keyDefinition: UserKeyDefinition<string>,
         userId?: UserId,
       ) => Observable<string>,
     ) => {
@@ -75,9 +76,14 @@ describe("DefaultStateProvider", () => {
         name: "name",
         status: AuthenticationStatus.LoggedOut,
       };
-      const keyDefinition = new KeyDefinition<string>(new StateDefinition("test", "disk"), "test", {
-        deserializer: (s) => s,
-      });
+      const keyDefinition = new UserKeyDefinition<string>(
+        new StateDefinition("test", "disk"),
+        "test",
+        {
+          deserializer: (s) => s,
+          clearOn: [],
+        },
+      );
 
       it("should follow the specified user if userId is provided", async () => {
         const state = singleUserStateProvider.getFake(userId, keyDefinition);
@@ -125,9 +131,14 @@ describe("DefaultStateProvider", () => {
       name: "name",
       status: AuthenticationStatus.LoggedOut,
     };
-    const keyDefinition = new KeyDefinition<string>(new StateDefinition("test", "disk"), "test", {
-      deserializer: (s) => s,
-    });
+    const keyDefinition = new UserKeyDefinition<string>(
+      new StateDefinition("test", "disk"),
+      "test",
+      {
+        deserializer: (s) => s,
+        clearOn: [],
+      },
+    );
 
     it("should not emit any values until a truthy user id is supplied", async () => {
       accountService.activeAccountSubject.next(null);
@@ -149,9 +160,14 @@ describe("DefaultStateProvider", () => {
   });
 
   describe("getUserStateOrDefault$", () => {
-    const keyDefinition = new KeyDefinition<string>(new StateDefinition("test", "disk"), "test", {
-      deserializer: (s) => s,
-    });
+    const keyDefinition = new UserKeyDefinition<string>(
+      new StateDefinition("test", "disk"),
+      "test",
+      {
+        deserializer: (s) => s,
+        clearOn: [],
+      },
+    );
 
     it("should emit default value if no userId supplied and first active user id emission in falsy", async () => {
       accountService.activeAccountSubject.next(null);
@@ -168,9 +184,14 @@ describe("DefaultStateProvider", () => {
   });
 
   describe("setUserState", () => {
-    const keyDefinition = new KeyDefinition<string>(new StateDefinition("test", "disk"), "test", {
-      deserializer: (s) => s,
-    });
+    const keyDefinition = new UserKeyDefinition<string>(
+      new StateDefinition("test", "disk"),
+      "test",
+      {
+        deserializer: (s) => s,
+        clearOn: [],
+      },
+    );
 
     it("should set the state for the active user if no userId is provided", async () => {
       const value = "value";
@@ -202,8 +223,9 @@ describe("DefaultStateProvider", () => {
   });
 
   it("should bind the activeUserStateProvider", () => {
-    const keyDefinition = new KeyDefinition(new StateDefinition("test", "disk"), "test", {
+    const keyDefinition = new UserKeyDefinition(new StateDefinition("test", "disk"), "test", {
       deserializer: () => null,
+      clearOn: [],
     });
     const existing = activeUserStateProvider.get(keyDefinition);
     const actual = sut.getActive(keyDefinition);
@@ -212,8 +234,9 @@ describe("DefaultStateProvider", () => {
 
   it("should bind the singleUserStateProvider", () => {
     const userId = "user" as UserId;
-    const keyDefinition = new KeyDefinition(new StateDefinition("test", "disk"), "test", {
+    const keyDefinition = new UserKeyDefinition(new StateDefinition("test", "disk"), "test", {
       deserializer: () => null,
+      clearOn: [],
     });
     const existing = singleUserStateProvider.get(userId, keyDefinition);
     const actual = sut.getUser(userId, keyDefinition);