bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-26 13:13:22 +00:00
Code Issues Releases Wiki Activity

Configure clippy (#16194)

Browse Source 
Apply the same clippy configuration as we have in sdk-internal. bitwarden/sdk-internal@49f84e6/Cargo.toml#L91-L94

Adds FIXME comments to all existing violations. unwrap is bad as those will resullt in panics and crash the application. Unused async is ignored in napi since that would require changes to the js side which I don't want to deal with.
This commit is contained in:
Oscar Hinton
2025-08-29 14:27:50 +02:00
committed by GitHub
parent 2b2912b1be
commit 97ee61db00
27 changed files with 131 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/desktop/desktop_native/windows_plugin_authenticator/src/lib.rs
View File

@@ -86,6 +86,8 @@ fn register_com_library() -> std::result::Result<(), String> {
}
/// Adds Bitwarden as a plugin authenticator.
// FIXME: Remove unwraps! They panic and terminate the whole application.
#[allow(clippy::unwrap_used)]
fn add_authenticator() -> std::result::Result<(), String> {
let authenticator_name: HSTRING = AUTHENTICATOR_NAME.into();
let authenticator_name_ptr = PCWSTR(authenticator_name.as_ptr()).as_ptr();