[PM-358] Bump electron to 24 and node to 18 (#5205)

Upgrade Electron to version 24, node to 18 and npm to 9. Electron changed to using node 18 in 23, with node 18 using npm 9 as default.

There doesn't seem to be any breaking changes except the deprecation of Windows 7, 8.1, and Server 2012. A somewhat undocumented breaking change was that elements in the title bar are now draggable which broke the account switching selector. Resolved by adding a no-drag css rule.

- electronjs.org/blog/electron-22-0
- electronjs.org/blog/electron-23-0
- electronjs.org/blog/electron-24-0

apps/desktop/src/auth/lock.component.html

@@ -73,9 +73,4 @@
       </div>
     </div>
   </div>
-  <ng-container *ngIf="oldOs">
-    <app-callout type="warning" class="os-deprecated">
-      {{ (deprecated ? "windows8Deprecated" : "windows8SoonDeprecated") | i18n }}
-    </app-callout>
-  </ng-container>
 </form>

apps/desktop/src/auth/lock.component.ts

@@ -1,5 +1,3 @@
-import * as os from "os";
-
 import { Component, NgZone } from "@angular/core";
 import { ActivatedRoute, Router } from "@angular/router";
 import { ipcRenderer } from "electron";
@@ -33,8 +31,6 @@ const BroadcasterSubscriptionId = "LockComponent";
 export class LockComponent extends BaseLockComponent {
   private deferFocus: boolean = null;
   protected biometricReady = false;
-  protected oldOs = false;
-  protected deprecated = false;
 
   constructor(
     router: Router,
@@ -74,20 +70,6 @@ export class LockComponent extends BaseLockComponent {
       policyService,
       passwordGenerationService
     );
-
-    if (process.platform === "win32") {
-      try {
-        const release = os.release();
-        const majorVersion = parseInt(release.split(".")[0], 10);
-
-        this.oldOs = majorVersion < 10;
-        if (new Date() > new Date("2023-05-31")) {
-          this.deprecated = true;
-        }
-      } catch (e) {
-        this.logService.error(e);
-      }
-    }
   }
 
   async ngOnInit() {

apps/desktop/src/auth/login/login.component.html

@@ -159,12 +159,6 @@
         </div>
       </ng-template>
     </div>
-
-    <ng-container *ngIf="oldOs">
-      <app-callout type="warning" class="os-deprecated">
-        {{ (deprecated ? "windows8Deprecated" : "windows8SoonDeprecated") | i18n }}
-      </app-callout>
-    </ng-container>
   </form>
 </div>
 <ng-template #environment></ng-template>

apps/desktop/src/auth/login/login.component.ts

@@ -1,5 +1,3 @@
-import * as os from "os";
-
 import { Component, NgZone, OnDestroy, ViewChild, ViewContainerRef } from "@angular/core";
 import { FormBuilder } from "@angular/forms";
 import { ActivatedRoute, Router } from "@angular/router";
@@ -39,8 +37,6 @@ export class LoginComponent extends BaseLoginComponent implements OnDestroy {
   showingModal = false;
 
   private deferFocus: boolean = null;
-  protected oldOs = false;
-  protected deprecated = false;
 
   get loggedEmail() {
     return this.formGroup.value.email;
@@ -93,20 +89,6 @@ export class LoginComponent extends BaseLoginComponent implements OnDestroy {
     super.onSuccessfulLogin = () => {
       return syncService.fullSync(true);
     };
-
-    if (process.platform === "win32") {
-      try {
-        const release = os.release();
-        const majorVersion = parseInt(release.split(".")[0], 10);
-
-        this.oldOs = majorVersion < 10;
-        if (new Date() > new Date("2023-05-31")) {
-          this.deprecated = true;
-        }
-      } catch (e) {
-        this.logService.error(e);
-      }
-    }
   }
 
   async ngOnInit() {