mirror of
https://github.com/bitwarden/browser
synced 2025-12-17 00:33:44 +00:00
[PM-358] Bump electron to 24 and node to 18 (#5205)
Upgrade Electron to version 24, node to 18 and npm to 9. Electron changed to using node 18 in 23, with node 18 using npm 9 as default. There doesn't seem to be any breaking changes except the deprecation of Windows 7, 8.1, and Server 2012. A somewhat undocumented breaking change was that elements in the title bar are now draggable which broke the account switching selector. Resolved by adding a no-drag css rule. - electronjs.org/blog/electron-22-0 - electronjs.org/blog/electron-23-0 - electronjs.org/blog/electron-24-0
This commit is contained in:
@@ -1,5 +1,3 @@
|
||||
import * as os from "os";
|
||||
|
||||
import { Component, NgZone } from "@angular/core";
|
||||
import { ActivatedRoute, Router } from "@angular/router";
|
||||
import { ipcRenderer } from "electron";
|
||||
@@ -33,8 +31,6 @@ const BroadcasterSubscriptionId = "LockComponent";
|
||||
export class LockComponent extends BaseLockComponent {
|
||||
private deferFocus: boolean = null;
|
||||
protected biometricReady = false;
|
||||
protected oldOs = false;
|
||||
protected deprecated = false;
|
||||
|
||||
constructor(
|
||||
router: Router,
|
||||
@@ -74,20 +70,6 @@ export class LockComponent extends BaseLockComponent {
|
||||
policyService,
|
||||
passwordGenerationService
|
||||
);
|
||||
|
||||
if (process.platform === "win32") {
|
||||
try {
|
||||
const release = os.release();
|
||||
const majorVersion = parseInt(release.split(".")[0], 10);
|
||||
|
||||
this.oldOs = majorVersion < 10;
|
||||
if (new Date() > new Date("2023-05-31")) {
|
||||
this.deprecated = true;
|
||||
}
|
||||
} catch (e) {
|
||||
this.logService.error(e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
async ngOnInit() {
|
||||
|
||||
Reference in New Issue
Block a user