mirror of
https://github.com/bitwarden/browser
synced 2025-12-20 02:03:39 +00:00
[PM-358] Bump electron to 24 and node to 18 (#5205)
Upgrade Electron to version 24, node to 18 and npm to 9. Electron changed to using node 18 in 23, with node 18 using npm 9 as default. There doesn't seem to be any breaking changes except the deprecation of Windows 7, 8.1, and Server 2012. A somewhat undocumented breaking change was that elements in the title bar are now draggable which broke the account switching selector. Resolved by adding a no-drag css rule. - electronjs.org/blog/electron-22-0 - electronjs.org/blog/electron-23-0 - electronjs.org/blog/electron-24-0
This commit is contained in:
@@ -31,6 +31,9 @@
|
||||
}
|
||||
|
||||
app-account-switcher {
|
||||
// Electron will mark elements in the title bar as draggable so that the window can be moved. This
|
||||
// disables the click events. To restore the click functionality, we mark this element as no-drag.
|
||||
-webkit-app-region: no-drag;
|
||||
justify-self: end;
|
||||
height: 100%;
|
||||
}
|
||||
|
||||
@@ -272,13 +272,3 @@
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// TODO: Remove after 2023.4 release
|
||||
.os-deprecated {
|
||||
margin-top: 20px;
|
||||
width: 500px;
|
||||
}
|
||||
|
||||
#lock-page {
|
||||
flex-direction: column;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user