Typescript-strict-plugin (#12235)

* Use typescript-strict-plugin to iteratively turn on strict

* Add strict testing to pipeline

Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files.

* turn on strict for scripts directory

* Use plugin for all tsconfigs in monorepo

vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes.

* remove plugin from configs that extend one that already has it

* Update workspace settings to honor strict plugin

* Apply strict-plugin to native message test runner

* Update vscode workspace to use root tsc version

* `./node_modules/.bin/update-strict-comments` 🤖

This is a one-time operation. All future files should adhere to strict type checking.

* Add fixme to `ts-strict-ignore` comments

* `update-strict-comments` 🤖

repeated for new merge files

libs/common/src/auth/abstractions/account.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Observable } from "rxjs";
 
 import { UserId } from "../../types/guid";

libs/common/src/auth/abstractions/anonymous-hub.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 export abstract class AnonymousHubService {
   createHubConnection: (token: string) => Promise<void>;
   stopHubConnection: () => Promise<void>;

libs/common/src/auth/abstractions/avatar.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Observable } from "rxjs";
 
 import { UserId } from "../../types/guid";

libs/common/src/auth/abstractions/device-trust.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Observable } from "rxjs";
 
 import { EncString } from "../../platform/models/domain/enc-string";

libs/common/src/auth/abstractions/devices-api.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { ListResponse } from "../../models/response/list.response";
 import { DeviceResponse } from "../abstractions/devices/responses/device.response";
 import { SecretVerificationRequest } from "../models/request/secret-verification.request";

libs/common/src/auth/abstractions/devices/devices.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Observable } from "rxjs";
 
 import { DeviceView } from "./views/device.view";

libs/common/src/auth/abstractions/devices/views/device.view.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { DeviceType } from "../../../../enums";
 import { View } from "../../../../models/view/view";
 import { DeviceResponse } from "../responses/device.response";

libs/common/src/auth/abstractions/key-connector.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Organization } from "../../admin-console/models/domain/organization";
 import { UserId } from "../../types/guid";
 import { IdentityTokenResponse } from "../models/response/identity-token.response";

libs/common/src/auth/abstractions/sso-login.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 export abstract class SsoLoginServiceAbstraction {
   /**
    * Gets the code verifier used for SSO.

libs/common/src/auth/abstractions/token.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Observable } from "rxjs";
 
 import { VaultTimeoutAction } from "../../enums/vault-timeout-action.enum";

libs/common/src/auth/abstractions/two-factor.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { TwoFactorProviderType } from "../enums/two-factor-provider-type";
 import { IdentityTwoFactorResponse } from "../models/response/identity-two-factor.response";
 

libs/common/src/auth/abstractions/user-verification/user-verification-api.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "../../models/request/secret-verification.request";
 import { VerifyOTPRequest } from "../../models/request/verify-otp.request";
 import { MasterPasswordPolicyResponse } from "../../models/response/master-password-policy.response";

libs/common/src/auth/abstractions/user-verification/user-verification.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { UserId } from "../../../types/guid";
 import { SecretVerificationRequest } from "../../models/request/secret-verification.request";
 import { UserVerificationOptions } from "../../types/user-verification-options";

libs/common/src/auth/abstractions/webauthn/webauthn-login-api.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { CredentialAssertionOptionsResponse } from "../../services/webauthn-login/response/credential-assertion-options.response";
 
 export class WebAuthnLoginApiServiceAbstraction {

libs/common/src/auth/abstractions/webauthn/webauthn-login-prf-key.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { PrfKey } from "../../../types/key";
 
 /**

libs/common/src/auth/abstractions/webauthn/webauthn-login.service.abstraction.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { AuthResult } from "../../models/domain/auth-result";
 import { WebAuthnLoginCredentialAssertionOptionsView } from "../../models/view/webauthn-login/webauthn-login-credential-assertion-options.view";
 import { WebAuthnLoginCredentialAssertionView } from "../../models/view/webauthn-login/webauthn-login-credential-assertion.view";

libs/common/src/auth/iframe-component.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 export abstract class IFrameComponent {
   iframe: HTMLIFrameElement;
   private connectorLink: HTMLAnchorElement;

libs/common/src/auth/models/api/sso-config.api.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { BaseResponse } from "../../../models/response/base.response";
 import {
   MemberDecryptionType,

libs/common/src/auth/models/domain/admin-auth-req-storable.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Jsonify } from "type-fest";
 
 import { Utils } from "../../../platform/misc/utils";

libs/common/src/auth/models/domain/auth-result.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Utils } from "../../../platform/misc/utils";
 import { UserId } from "../../../types/guid";
 import { TwoFactorProviderType } from "../../enums/two-factor-provider-type";

libs/common/src/auth/models/request/captcha-protected.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 export abstract class CaptchaProtectedRequest {
   captchaResponse: string = null;
 }

libs/common/src/auth/models/request/disable-two-factor-authenticator.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { TwoFactorProviderRequest } from "./two-factor-provider.request";
 
 export class DisableTwoFactorAuthenticatorRequest extends TwoFactorProviderRequest {

libs/common/src/auth/models/request/email-token.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class EmailTokenRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/email.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { EmailTokenRequest } from "./email-token.request";
 
 export class EmailRequest extends EmailTokenRequest {

libs/common/src/auth/models/request/identity-token/device.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Jsonify } from "type-fest";
 
 import { DeviceType } from "../../../../enums";

libs/common/src/auth/models/request/identity-token/token-two-factor.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { TwoFactorProviderType } from "../../../enums/two-factor-provider-type";
 
 export class TokenTwoFactorRequest {

libs/common/src/auth/models/request/identity-token/token.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { DeviceRequest } from "./device.request";
 import { TokenTwoFactorRequest } from "./token-two-factor.request";
 

libs/common/src/auth/models/request/organization-sso.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SsoConfigApi } from "../api/sso-config.api";
 
 export class OrganizationSsoRequest {

libs/common/src/auth/models/request/password.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class PasswordRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/secret-verification.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 export class SecretVerificationRequest {
   masterPasswordHash: string;
   otp: string;

libs/common/src/auth/models/request/two-factor-email.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class TwoFactorEmailRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/two-factor-provider.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { TwoFactorProviderType } from "../../enums/two-factor-provider-type";
 
 import { SecretVerificationRequest } from "./secret-verification.request";

libs/common/src/auth/models/request/two-factor-recovery.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class TwoFactorRecoveryRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/update-devices-trust.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class UpdateDevicesTrustRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/update-tde-offboarding-password.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { OrganizationUserResetPasswordRequest } from "@bitwarden/admin-console/common";
 
 export class UpdateTdeOffboardingPasswordRequest extends OrganizationUserResetPasswordRequest {

libs/common/src/auth/models/request/update-temp-password.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { OrganizationUserResetPasswordRequest } from "@bitwarden/admin-console/common";
 
 export class UpdateTempPasswordRequest extends OrganizationUserResetPasswordRequest {

libs/common/src/auth/models/request/update-two-factor-authenticator.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class UpdateTwoFactorAuthenticatorRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/update-two-factor-duo.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class UpdateTwoFactorDuoRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/update-two-factor-email.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class UpdateTwoFactorEmailRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/update-two-factor-web-authn-delete.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class UpdateTwoFactorWebAuthnDeleteRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/update-two-factor-web-authn.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class UpdateTwoFactorWebAuthnRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/update-two-factor-yubikey-otp.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { SecretVerificationRequest } from "./secret-verification.request";
 
 export class UpdateTwoFactorYubikeyOtpRequest extends SecretVerificationRequest {

libs/common/src/auth/models/request/webauthn-rotate-credential.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { EncString } from "@bitwarden/common/platform/models/domain/enc-string";
 
 import { RotateableKeySet } from "../../../../../auth/src/common/models";

libs/common/src/auth/models/response/identity-token.response.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { KdfType } from "@bitwarden/key-management";
 
 import { BaseResponse } from "../../../models/response/base.response";

libs/common/src/auth/models/response/organization-sso.response.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { BaseResponse } from "../../../models/response/base.response";
 import { SsoConfigApi } from "../api/sso-config.api";
 

libs/common/src/auth/models/response/protected-device.response.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Jsonify } from "type-fest";
 
 import { DeviceType } from "../../../enums";

libs/common/src/auth/models/response/user-decryption-options/trusted-device-user-decryption-option.response.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { BaseResponse } from "../../../../models/response/base.response";
 import { EncString } from "../../../../platform/models/domain/enc-string";
 

libs/common/src/auth/models/response/user-decryption-options/webauthn-prf-decryption-option.response.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { BaseResponse } from "../../../../models/response/base.response";
 import { EncString } from "../../../../platform/models/domain/enc-string";
 

libs/common/src/auth/models/view/sso-config.view.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { View } from "../../../models/view/view";
 import {
   MemberDecryptionType,

libs/common/src/auth/services/account.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import {
   combineLatestWith,
   map,

libs/common/src/auth/services/anonymous-hub.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import {
   HttpTransportType,
   HubConnection,

libs/common/src/auth/services/auth.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import {
   Observable,
   combineLatest,

libs/common/src/auth/services/avatar.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Observable } from "rxjs";
 
 import { ApiService } from "../../abstractions/api.service";

libs/common/src/auth/services/device-trust.service.implementation.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom, map, Observable } from "rxjs";
 
 import { UserDecryptionOptionsServiceAbstraction } from "@bitwarden/auth/common";

libs/common/src/auth/services/devices-api.service.implementation.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { ApiService } from "../../abstractions/api.service";
 import { ListResponse } from "../../models/response/list.response";
 import { Utils } from "../../platform/misc/utils";

libs/common/src/auth/services/key-connector.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom } from "rxjs";
 
 import { LogoutReason } from "@bitwarden/auth/common";

libs/common/src/auth/services/master-password/fake-master-password.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { mock } from "jest-mock-extended";
 import { ReplaySubject, Observable } from "rxjs";
 

libs/common/src/auth/services/master-password/master-password.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom, map, Observable } from "rxjs";
 
 import { LogService } from "@bitwarden/common/platform/abstractions/log.service";

libs/common/src/auth/services/password-reset-enrollment.service.implementation.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom, map } from "rxjs";
 
 import {

libs/common/src/auth/services/sso-login.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom } from "rxjs";
 
 import {

libs/common/src/auth/services/token.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Observable, combineLatest, firstValueFrom, map } from "rxjs";
 import { Opaque } from "type-fest";
 

libs/common/src/auth/services/two-factor.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom, map } from "rxjs";
 
 import { I18nService } from "../../platform/abstractions/i18n.service";

libs/common/src/auth/services/user-verification/user-verification.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { firstValueFrom, map } from "rxjs";
 
 import { UserDecryptionOptionsServiceAbstraction } from "@bitwarden/auth/common";

libs/common/src/auth/services/webauthn-login/request/webauthn-login-assertion-response.request.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { Jsonify } from "type-fest";
 
 import { Utils } from "../../../../platform/misc/utils";

libs/common/src/auth/services/webauthn-login/webauthn-login.service.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { LoginStrategyServiceAbstraction, WebAuthnLoginCredentials } from "@bitwarden/auth/common";
 
 import { LogService } from "../../../platform/abstractions/log.service";

libs/common/src/auth/webauthn-iframe.ts

@@ -1,3 +1,5 @@
+// FIXME: Update this file to be type safe and remove this and next line
+// @ts-strict-ignore
 import { I18nService } from "../platform/abstractions/i18n.service";
 import { PlatformUtilsService } from "../platform/abstractions/platform-utils.service";