From 9eceaa3d4c929e4dc40fb4bf3415580f655f4d6c Mon Sep 17 00:00:00 2001 From: Daniel Riera Date: Mon, 28 Jul 2025 09:55:20 -0400 Subject: [PATCH] PM-19574 Browser Autofill overlay displays outdated data (#15624) * PM-19574 * explicitly set true * remove delete cipher call to address the issue at the core separately * add test --- .../add-edit/add-edit-v2.component.spec.ts | 14 ++++++++++++++ .../vault-v2/add-edit/add-edit-v2.component.ts | 1 + 2 files changed, 15 insertions(+) diff --git a/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.spec.ts b/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.spec.ts index 216ec1c3f1b..1bffcd9ad51 100644 --- a/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.spec.ts +++ b/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.spec.ts @@ -26,6 +26,7 @@ import { } from "@bitwarden/vault"; import { BrowserFido2UserInterfaceSession } from "../../../../../autofill/fido2/services/browser-fido2-user-interface.service"; +import { BrowserApi } from "../../../../../platform/browser/browser-api"; import BrowserPopupUtils from "../../../../../platform/browser/browser-popup-utils"; import { PopupRouterCacheService } from "../../../../../platform/popup/view-cache/popup-router-cache.service"; import { PopupCloseWarningService } from "../../../../../popup/services/popup-close-warning.service"; @@ -309,6 +310,19 @@ describe("AddEditV2Component", () => { expect(navigate).not.toHaveBeenCalled(); expect(back).toHaveBeenCalled(); }); + + it.each(["add", "edit", "partial-edit"])( + "sends the addEditCipherSubmitted message when a cipher is edited, added or partially edited", + async (mode) => { + const sendMessageSpy = jest.spyOn(BrowserApi, "sendMessage"); + component.config.mode = mode; + + await component.onCipherSaved({ id: "123-456-789" } as CipherView); + + expect(sendMessageSpy).toHaveBeenCalled(); + expect(sendMessageSpy).toHaveBeenCalledWith("addEditCipherSubmitted"); + }, + ); }); describe("handleBackButton", () => { diff --git a/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.ts b/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.ts index f019636e690..3985fc85a54 100644 --- a/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.ts +++ b/apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.ts @@ -268,6 +268,7 @@ export class AddEditV2Component implements OnInit { // Clear popup history so after closing/reopening, Back won’t return to the add-edit form await this.popupRouterCacheService.setHistory([]); } + await BrowserApi.sendMessage("addEditCipherSubmitted"); } subscribeToParams(): void {