mirror of
https://github.com/bitwarden/browser
synced 2025-12-06 00:13:28 +00:00
Workflow corrections (#17392)
Co-authored-by: Amy Galles <9685081+AmyLGalles@users.noreply.github.com>
This commit is contained in:
2
.github/workflows/build-desktop.yml
vendored
2
.github/workflows/build-desktop.yml
vendored
@@ -627,7 +627,7 @@ jobs:
|
|||||||
if: ${{ needs.setup.outputs.has_secrets == 'true' }}
|
if: ${{ needs.setup.outputs.has_secrets == 'true' }}
|
||||||
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
|
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
|
||||||
with:
|
with:
|
||||||
name: Bitwarden-Installer-${{ env._PACKAGE_VERSION }}..exe
|
name: Bitwarden-Installer-${{ env._PACKAGE_VERSION }}.exe
|
||||||
path: apps/desktop/dist/nsis-web/Bitwarden-Installer-${{ env._PACKAGE_VERSION }}.exe
|
path: apps/desktop/dist/nsis-web/Bitwarden-Installer-${{ env._PACKAGE_VERSION }}.exe
|
||||||
if-no-files-found: error
|
if-no-files-found: error
|
||||||
|
|
||||||
|
|||||||
2
.github/workflows/publish-cli.yml
vendored
2
.github/workflows/publish-cli.yml
vendored
@@ -206,7 +206,7 @@ jobs:
|
|||||||
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
|
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
|
||||||
with:
|
with:
|
||||||
persist-credentials: false
|
persist-credentials: false
|
||||||
|
|
||||||
- name: Get Node version
|
- name: Get Node version
|
||||||
id: retrieve-node-version
|
id: retrieve-node-version
|
||||||
working-directory: ./
|
working-directory: ./
|
||||||
|
|||||||
8
.github/workflows/publish-desktop.yml
vendored
8
.github/workflows/publish-desktop.yml
vendored
@@ -336,7 +336,7 @@ jobs:
|
|||||||
ruby-version: '3.4.7'
|
ruby-version: '3.4.7'
|
||||||
bundler-cache: false
|
bundler-cache: false
|
||||||
working-directory: apps/desktop
|
working-directory: apps/desktop
|
||||||
|
|
||||||
- name: Install Fastlane
|
- name: Install Fastlane
|
||||||
working-directory: apps/desktop
|
working-directory: apps/desktop
|
||||||
run: gem install fastlane
|
run: gem install fastlane
|
||||||
@@ -377,15 +377,15 @@ jobs:
|
|||||||
echo "📦 Publishing build $BUILD_NUMBER to Mac App Store"
|
echo "📦 Publishing build $BUILD_NUMBER to Mac App Store"
|
||||||
IS_DRY_RUN="false"
|
IS_DRY_RUN="false"
|
||||||
fi
|
fi
|
||||||
|
|
||||||
echo "📝 Release notes (${#CHANGELOG} chars): ${CHANGELOG:0:100}..."
|
echo "📝 Release notes (${#CHANGELOG} chars): ${CHANGELOG:0:100}..."
|
||||||
|
|
||||||
# Validate changelog length (App Store limit is 4000 chars)
|
# Validate changelog length (App Store limit is 4000 chars)
|
||||||
if [ ${#CHANGELOG} -gt 4000 ]; then
|
if [ ${#CHANGELOG} -gt 4000 ]; then
|
||||||
echo "❌ Release notes too long: ${#CHANGELOG} characters (max 4000)"
|
echo "❌ Release notes too long: ${#CHANGELOG} characters (max 4000)"
|
||||||
exit 1
|
exit 1
|
||||||
fi
|
fi
|
||||||
|
|
||||||
fastlane publish --verbose \
|
fastlane publish --verbose \
|
||||||
app_version:"${_PKG_VERSION}" \
|
app_version:"${_PKG_VERSION}" \
|
||||||
build_number:"$BUILD_NUMBER" \
|
build_number:"$BUILD_NUMBER" \
|
||||||
|
|||||||
Reference in New Issue
Block a user