mirror of
https://github.com/bitwarden/browser
synced 2025-12-22 19:23:52 +00:00
[PM-25682] Migrate CipherView and subviews to be TS strict compliant (#16463)
* [PM-25682] Remove ts-strict-ignore from Vault view models and update types to be strict * [PM-25682] Ignore ViewEncryptableKeys error for old decrypt methods * [PM-25682] Add null/undefined as possible types for isNull* and other helpers that include null checks internally * [PM-25682] Use patchValue instead of setValue which does not support undefined values * [PM-25682] Add type assertions and other misc. null checks where necessary * [PM-25682] Fix importers specs * [PM-25682] Cleanup card view/details * [PM-25682] Fix cipher view hasAttachment helper * [PM-25682] Cleanup unecessary null assignments in notification.background.spec.ts * [PM-25682] Ensure linkedId is undefined instead of null * [PM-25682] Cleanup misc typing errors * [PM-25682] Make the CipherId required * [PM-25682] Undo CipherId assertions * [PM-25682] Undo brand initial value change * [PM-25682] Update SshKeyView * [PM-25682] Add constructor to Fido2CredentialView * [PM-25682] Prettier * [PM-25682] Fix strict type warnings after merge with main * [PM-25682] Cleanup cipher view spec * [PM-25682] Cleanup new type warnings after merge * [PM-25682] Undo removed eslint-disable-next-line comment * [PM-25682] Fix flaky test * [PM-25682] Use satisfies instead of as for Fido2CredentialAutofillView
This commit is contained in:
@@ -133,19 +133,11 @@ describe("NotificationBackground", () => {
|
||||
|
||||
expect(cipherView.name).toEqual("example.com");
|
||||
expect(cipherView.login).toEqual({
|
||||
autofillOnPageLoad: null,
|
||||
fido2Credentials: null,
|
||||
fido2Credentials: [],
|
||||
password: message.password,
|
||||
passwordRevisionDate: null,
|
||||
totp: null,
|
||||
uris: [
|
||||
{
|
||||
_canLaunch: null,
|
||||
_domain: null,
|
||||
_host: null,
|
||||
_hostname: null,
|
||||
_uri: message.uri,
|
||||
match: null,
|
||||
},
|
||||
],
|
||||
username: message.username,
|
||||
|
||||
@@ -1271,7 +1271,6 @@ export default class NotificationBackground {
|
||||
cipherView.folderId = folderId;
|
||||
cipherView.type = CipherType.Login;
|
||||
cipherView.login = loginView;
|
||||
cipherView.organizationId = null;
|
||||
|
||||
return cipherView;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user