bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 14:53:33 +00:00
Code Issues Releases Wiki Activity

Auth/ps 2465 fix knowndevices path (#4710)

Browse Source 
* PS-2450 EC-1073 Do not decode and normalize query

Co-authored-by: Jake Fink <jfink@bitwarden.com>

* Use encoded query parameters over path

* Prefer POST for requests with sensitive information

* Send private information in headers over query

* B64 encode email

---------

Co-authored-by: Jake Fink <jfink@bitwarden.com>
This commit is contained in:
Matt Gibson
2023-03-07 13:49:12 -05:00
committed by GitHub
parent 6876aad883
commit a16d02b39d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/common/src/services/api.service.ts
View File

@@ -1212,8 +1212,10 @@ export class ApiService implements ApiServiceAbstraction {
} }
async getKnownDevice(email: string, deviceIdentifier: string): Promise<boolean> { async getKnownDevice(email: string, deviceIdentifier: string): Promise<boolean> {
const path = `/devices/knowndevice/${email}/${deviceIdentifier}`; const r = await this.send("GET", "/devices/knowndevice", null, false, true, null, (headers) => {
const r = await this.send("GET", path, null, false, true); headers.set("X-Device-Identifier", deviceIdentifier);
headers.set("X-Request-Email", Utils.fromUtf8ToUrlB64(email));
});
return r as boolean; return r as boolean;
} }