Add and fix tests

libs/auth/src/angular/two-factor-auth/abstractions/two-factor-form-cache.service.abstraction.ts

@@ -1,4 +1,4 @@
-import { Observable } from "rxjs";
+import { Observable, firstValueFrom } from "rxjs";
 
 import { TwoFactorProviderType } from "@bitwarden/common/auth/enums/two-factor-provider-type";
 
@@ -17,30 +17,36 @@ export interface TwoFactorFormData {
  */
 export abstract class TwoFactorFormCacheService {
   /**
-   * Check if the form persistence feature is enabled
-   */
-  abstract isEnabled(): Promise<boolean>;
-
-  /**
-   * Observable that emits the current enabled state
+   * Observable that emits the current enabled state of the feature flag
    */
   abstract isEnabled$(): Observable<boolean>;
 
+  /**
+   * Helper method that returns whether the feature is enabled
+   * @returns A promise that resolves to true if the feature is enabled
+   */
+  async isEnabled(): Promise<boolean> {
+    return firstValueFrom(this.isEnabled$());
+  }
+
   /**
    * Save form data to persistent storage
    */
   abstract saveFormData(data: TwoFactorFormData): Promise<void>;
 
-  /**
-   * Retrieve form data from persistent storage
-   */
-  abstract getFormData(): Promise<TwoFactorFormData | null>;
-
   /**
    * Observable that emits the current form data
    */
   abstract formData$(): Observable<TwoFactorFormData | null>;
 
+  /**
+   * Helper method to retrieve form data
+   * @returns A promise that resolves to the form data
+   */
+  async getFormData(): Promise<TwoFactorFormData | null> {
+    return firstValueFrom(this.formData$());
+  }
+
   /**
    * Clear form data from persistent storage
    */

libs/auth/src/angular/two-factor-auth/two-factor-auth.component.spec.ts

@@ -1,10 +1,8 @@
-// FIXME: Update this file to be type safe and remove this and next line
-// @ts-strict-ignore
 import { Component } from "@angular/core";
 import { ComponentFixture, TestBed } from "@angular/core/testing";
-import { ActivatedRoute, convertToParamMap, Router } from "@angular/router";
+import { ActivatedRoute, Router, convertToParamMap } from "@angular/router";
 import { mock, MockProxy } from "jest-mock-extended";
-import { BehaviorSubject } from "rxjs";
+import { BehaviorSubject, of } from "rxjs";
 
 // eslint-disable-next-line no-restricted-imports
 import { WINDOW } from "@bitwarden/angular/services/injection-tokens";
@@ -39,6 +37,7 @@ import { DialogService, ToastService } from "@bitwarden/components";
 
 import { AnonLayoutWrapperDataService } from "../anon-layout/anon-layout-wrapper-data.service";
 
+import { TwoFactorFormCacheService } from "./abstractions/two-factor-form-cache.service.abstraction";
 import { TwoFactorAuthComponentService } from "./two-factor-auth-component.service";
 import { TwoFactorAuthComponent } from "./two-factor-auth.component";
 
@@ -73,6 +72,7 @@ describe("TwoFactorAuthComponent", () => {
   let anonLayoutWrapperDataService: MockProxy<AnonLayoutWrapperDataService>;
   let mockEnvService: MockProxy<EnvironmentService>;
   let mockLoginSuccessHandlerService: MockProxy<LoginSuccessHandlerService>;
+  let mockTwoFactorFormCacheService: MockProxy<TwoFactorFormCacheService>;
 
   let mockUserDecryptionOpts: {
     noMasterPassword: UserDecryptionOptions;
@@ -113,6 +113,10 @@ describe("TwoFactorAuthComponent", () => {
 
     anonLayoutWrapperDataService = mock<AnonLayoutWrapperDataService>();
 
+    mockTwoFactorFormCacheService = mock<TwoFactorFormCacheService>();
+    mockTwoFactorFormCacheService.isEnabled$.mockReturnValue(of(false));
+    mockTwoFactorFormCacheService.formData$.mockReturnValue(of(null));
+
     mockUserDecryptionOpts = {
       noMasterPassword: new UserDecryptionOptions({
         hasMasterPassword: false,
@@ -195,6 +199,7 @@ describe("TwoFactorAuthComponent", () => {
         { provide: EnvironmentService, useValue: mockEnvService },
         { provide: AnonLayoutWrapperDataService, useValue: anonLayoutWrapperDataService },
         { provide: LoginSuccessHandlerService, useValue: mockLoginSuccessHandlerService },
+        { provide: TwoFactorFormCacheService, useValue: mockTwoFactorFormCacheService },
       ],
     });