bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 13:53:34 +00:00
Code Issues Releases Wiki Activity

PM-26495 Activity tab empty state changed (#16726)

Browse Source
This commit is contained in:
Vijay Oommen
2025-10-03 12:03:00 -05:00
committed by GitHub
parent a690e9a626
commit a3696ea3c1
3 changed files with 3 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/web/src/locales/en/messages.json
View File

@@ -93,7 +93,7 @@
"sendReminders": { "sendReminders": {
"message": "Send reminders" "message": "Send reminders"
}, },
"criticalApplicationsActivityDescription": { "onceYouMarkApplicationsCriticalTheyWillDisplayHere": {
"message": "Once you mark applications critical, they will display here." "message": "Once you mark applications critical, they will display here."
}, },
"viewAtRiskMembers": { "viewAtRiskMembers": {

14
bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-activity.component.html
View File

@@ -4,19 +4,7 @@
</div> </div>
} }
@if (!(isLoading$ | async) && (noData$ | async)) { @if (!(isLoading$ | async)) {
<div class="tw-mt-4">
<bit-no-items class="tw-text-main">
<ng-container slot="title">
<h2 class="tw-font-semibold tw-mt-4">
{{ "noAppsInOrgTitle" | i18n: organization?.name }}
</h2>
</ng-container>
</bit-no-items>
</div>
}
@if (!(isLoading$ | async) && !(noData$ | async)) {
<ul <ul
class="tw-inline-grid tw-grid-cols-3 tw-gap-6 tw-m-0 tw-p-0 tw-w-full tw-auto-cols-auto tw-list-none" class="tw-inline-grid tw-grid-cols-3 tw-gap-6 tw-m-0 tw-p-0 tw-w-full tw-auto-cols-auto tw-list-none"
> >

4
bitwarden_license/bit-web/src/app/dirt/access-intelligence/all-activity.component.ts
View File

@@ -1,7 +1,7 @@
import { Component, DestroyRef, inject, OnInit } from "@angular/core"; import { Component, DestroyRef, inject, OnInit } from "@angular/core";
import { takeUntilDestroyed } from "@angular/core/rxjs-interop"; import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
import { ActivatedRoute } from "@angular/router"; import { ActivatedRoute } from "@angular/router";
import { BehaviorSubject, firstValueFrom } from "rxjs"; import { firstValueFrom } from "rxjs";
import { import {
AllActivitiesService, AllActivitiesService,
@@ -31,7 +31,6 @@ import { RiskInsightsTabType } from "./risk-insights.component";
}) })
export class AllActivityComponent implements OnInit { export class AllActivityComponent implements OnInit {
protected isLoading$ = this.dataService.isLoading$; protected isLoading$ = this.dataService.isLoading$;
protected noData$ = new BehaviorSubject(true);
organization: Organization | null = null; organization: Organization | null = null;
totalCriticalAppsAtRiskMemberCount = 0; totalCriticalAppsAtRiskMemberCount = 0;
totalCriticalAppsCount = 0; totalCriticalAppsCount = 0;
@@ -53,7 +52,6 @@ export class AllActivityComponent implements OnInit {
this.allActivitiesService.reportSummary$ this.allActivitiesService.reportSummary$
.pipe(takeUntilDestroyed(this.destroyRef)) .pipe(takeUntilDestroyed(this.destroyRef))
.subscribe((summary) => { .subscribe((summary) => {
this.noData$.next(summary.totalApplicationCount === 0);
this.totalCriticalAppsAtRiskMemberCount = summary.totalCriticalAtRiskMemberCount; this.totalCriticalAppsAtRiskMemberCount = summary.totalCriticalAtRiskMemberCount;
this.totalCriticalAppsCount = summary.totalCriticalApplicationCount; this.totalCriticalAppsCount = summary.totalCriticalApplicationCount;
this.totalCriticalAppsAtRiskCount = summary.totalCriticalAtRiskApplicationCount; this.totalCriticalAppsAtRiskCount = summary.totalCriticalAtRiskApplicationCount;