1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 13:53:34 +00:00

PM-26495 Activity tab empty state changed (#16726)

This commit is contained in:
Vijay Oommen
2025-10-03 12:03:00 -05:00
committed by GitHub
parent a690e9a626
commit a3696ea3c1
3 changed files with 3 additions and 17 deletions

View File

@@ -93,7 +93,7 @@
"sendReminders": {
"message": "Send reminders"
},
"criticalApplicationsActivityDescription": {
"onceYouMarkApplicationsCriticalTheyWillDisplayHere": {
"message": "Once you mark applications critical, they will display here."
},
"viewAtRiskMembers": {

View File

@@ -4,19 +4,7 @@
</div>
}
@if (!(isLoading$ | async) && (noData$ | async)) {
<div class="tw-mt-4">
<bit-no-items class="tw-text-main">
<ng-container slot="title">
<h2 class="tw-font-semibold tw-mt-4">
{{ "noAppsInOrgTitle" | i18n: organization?.name }}
</h2>
</ng-container>
</bit-no-items>
</div>
}
@if (!(isLoading$ | async) && !(noData$ | async)) {
@if (!(isLoading$ | async)) {
<ul
class="tw-inline-grid tw-grid-cols-3 tw-gap-6 tw-m-0 tw-p-0 tw-w-full tw-auto-cols-auto tw-list-none"
>

View File

@@ -1,7 +1,7 @@
import { Component, DestroyRef, inject, OnInit } from "@angular/core";
import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
import { ActivatedRoute } from "@angular/router";
import { BehaviorSubject, firstValueFrom } from "rxjs";
import { firstValueFrom } from "rxjs";
import {
AllActivitiesService,
@@ -31,7 +31,6 @@ import { RiskInsightsTabType } from "./risk-insights.component";
})
export class AllActivityComponent implements OnInit {
protected isLoading$ = this.dataService.isLoading$;
protected noData$ = new BehaviorSubject(true);
organization: Organization | null = null;
totalCriticalAppsAtRiskMemberCount = 0;
totalCriticalAppsCount = 0;
@@ -53,7 +52,6 @@ export class AllActivityComponent implements OnInit {
this.allActivitiesService.reportSummary$
.pipe(takeUntilDestroyed(this.destroyRef))
.subscribe((summary) => {
this.noData$.next(summary.totalApplicationCount === 0);
this.totalCriticalAppsAtRiskMemberCount = summary.totalCriticalAtRiskMemberCount;
this.totalCriticalAppsCount = summary.totalCriticalApplicationCount;
this.totalCriticalAppsAtRiskCount = summary.totalCriticalAtRiskApplicationCount;