1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00

dont allow shorthand property assignments

This commit is contained in:
Kyle Spearrin
2017-12-06 14:23:34 -05:00
parent 5319568d81
commit a4127f2571
24 changed files with 30 additions and 28 deletions

View File

@@ -420,18 +420,19 @@ export default class MainBackground {
return; return;
} }
const self = this;
const tab = await this.tabsQueryFirst({ active: true, windowId: chrome.windows.WINDOW_ID_CURRENT }); const tab = await this.tabsQueryFirst({ active: true, windowId: chrome.windows.WINDOW_ID_CURRENT });
if (!tab) { if (!tab) {
return; return;
} }
const disabled = await this.utilsService.getObjFromStorage<boolean>(ConstantsService.disableContextMenuItemKey); const disabled = await self.utilsService.getObjFromStorage<boolean>(ConstantsService.disableContextMenuItemKey);
if (!disabled) { if (!disabled) {
await this.buildContextMenu(); await this.buildContextMenu();
this.contextMenuReady(tab, true); this.contextMenuReady(tab, true);
} else { } else {
await this.contextMenusRemoveAll(); await this.contextMenusRemoveAll();
this.contextMenuReady(tab, false); self.contextMenuReady(tab, false);
} }
} }

View File

@@ -47,5 +47,5 @@ export const ActionButtonsComponent = {
onView: '&', onView: '&',
}, },
controller: ActionButtonsController, controller: ActionButtonsController,
template, template: template,
}; };

View File

@@ -11,11 +11,11 @@ export class CipherItemsController implements ng.IController {
} }
view(cipher: any) { view(cipher: any) {
return this.onView({cipher}); return this.onView({ cipher: cipher });
} }
select(cipher: any) { select(cipher: any) {
return this.onSelected({cipher}); return this.onSelected({ cipher: cipher });
} }
} }
@@ -27,5 +27,5 @@ export const CipherItemsComponent = {
onView: '&', onView: '&',
}, },
controller: CipherItemsController, controller: CipherItemsController,
template, template: template,
}; };

View File

@@ -78,5 +78,5 @@ export const IconComponent = {
cipher: '<', cipher: '<',
}, },
controller: IconController, controller: IconController,
template, template: template,
}; };

View File

@@ -56,5 +56,5 @@ export class PopOutController implements ng.IController {
export const PopOutComponent = { export const PopOutComponent = {
bindings: {}, bindings: {},
controller: PopOutController, controller: PopOutController,
template, template: template,
}; };

View File

@@ -69,7 +69,7 @@ export class CurrentController {
} }
this.autofillService.doAutoFill({ this.autofillService.doAutoFill({
cipher, cipher: cipher,
pageDetails: this.pageDetails, pageDetails: this.pageDetails,
fromBackground: false, fromBackground: false,
}).then((totpCode: string) => { }).then((totpCode: string) => {
@@ -165,5 +165,5 @@ export class CurrentController {
export const CurrentComponent = { export const CurrentComponent = {
bindings: {}, bindings: {},
controller: CurrentController, controller: CurrentController,
template, template: template,
}; };

View File

@@ -59,5 +59,5 @@ export class LockController {
export const LockComponent = { export const LockComponent = {
bindings: {}, bindings: {},
controller: LockController, controller: LockController,
template, template: template,
}; };

View File

@@ -15,5 +15,5 @@ export class AboutController {
export const AboutComponent = { export const AboutComponent = {
bindings: {}, bindings: {},
controller: AboutController, controller: AboutController,
template, template: template,
}; };

View File

@@ -19,5 +19,5 @@ export class CreditsController {
export const CreditsComponent = { export const CreditsComponent = {
bindings: {}, bindings: {},
controller: CreditsController, controller: CreditsController,
template, template: template,
}; };

View File

@@ -51,5 +51,5 @@ export class EnvironmentController {
export const EnvironmentComponent = { export const EnvironmentComponent = {
bindings: {}, bindings: {},
controller: EnvironmentController, controller: EnvironmentController,
template, template: template,
}; };

View File

@@ -40,5 +40,5 @@ export class AddFolderController {
export const AddFolderComponent = { export const AddFolderComponent = {
bindings: {}, bindings: {},
controller: AddFolderController, controller: AddFolderController,
template, template: template,
}; };

View File

@@ -74,5 +74,5 @@ export const EditFolderComponent = {
$transition$: '<', $transition$: '<',
}, },
controller: EditFolderController, controller: EditFolderController,
template, template: template,
}; };

View File

@@ -35,5 +35,5 @@ export class FoldersController {
export const FoldersComponent = { export const FoldersComponent = {
bindings: {}, bindings: {},
controller: FoldersController, controller: FoldersController,
template, template: template,
}; };

View File

@@ -31,5 +31,5 @@ export class HelpController {
export const HelpComponent = { export const HelpComponent = {
bindings: {}, bindings: {},
controller: HelpController, controller: HelpController,
template, template: template,
}; };

View File

@@ -91,5 +91,5 @@ export class OptionsController {
export const OptionsComponent = { export const OptionsComponent = {
bindings: {}, bindings: {},
controller: OptionsController, controller: OptionsController,
template, template: template,
}; };

View File

@@ -56,5 +56,5 @@ export class PremiumController {
export const PremiumComponent = { export const PremiumComponent = {
bindings: {}, bindings: {},
controller: PremiumController, controller: PremiumController,
template, template: template,
}; };

View File

@@ -148,5 +148,5 @@ export class SettingsController {
export const SettingsComponent = { export const SettingsComponent = {
bindings: {}, bindings: {},
controller: SettingsController, controller: SettingsController,
template, template: template,
}; };

View File

@@ -38,5 +38,5 @@ export class SyncController {
export const SyncComponent = { export const SyncComponent = {
bindings: {}, bindings: {},
controller: SyncController, controller: SyncController,
template, template: template,
}; };

View File

@@ -166,5 +166,5 @@ export class ExportController {
export const ExportComponent = { export const ExportComponent = {
bindings: {}, bindings: {},
controller: ExportController, controller: ExportController,
template, template: template,
}; };

View File

@@ -50,5 +50,5 @@ export const PasswordGeneratorHistoryComponent = {
$transition$: '<', $transition$: '<',
}, },
controller: PasswordGeneratorHistoryController, controller: PasswordGeneratorHistoryController,
template, template: template,
}; };

View File

@@ -140,5 +140,5 @@ export const PasswordGeneratorComponent = {
$transition$: '<', $transition$: '<',
}, },
controller: PasswordGeneratorController, controller: PasswordGeneratorController,
template, template: template,
}; };

View File

@@ -56,5 +56,5 @@ export class ToolsController {
export const ToolsComponent = { export const ToolsComponent = {
bindings: {}, bindings: {},
controller: ToolsController, controller: ToolsController,
template, template: template,
}; };

View File

@@ -18,10 +18,10 @@ export default function i18nService(utilsService: UtilsService) {
} }
return new Proxy({}, { return new Proxy({}, {
get(target, name) { get: (target, name) => {
return chrome.i18n.getMessage(name); return chrome.i18n.getMessage(name);
}, },
set(target, name, value) { set: (target, name, value) => {
return false; return false;
}, },
}); });

View File

@@ -36,6 +36,7 @@
], ],
"no-empty": [ true, "allow-empty-catch" ], "no-empty": [ true, "allow-empty-catch" ],
"object-literal-sort-keys": false, "object-literal-sort-keys": false,
"object-literal-shorthand": [ true, "never" ],
"prefer-for-of": false, "prefer-for-of": false,
"quotemark": [ true, "single" ], "quotemark": [ true, "single" ],
"whitespace": [ "whitespace": [