From a45f053a7f8d8efa8e58c7dc466f3464d8002395 Mon Sep 17 00:00:00 2001
From: Oscar Hinton <Hinton@users.noreply.github.com>
Date: Tue, 19 Aug 2025 11:13:22 +0200
Subject: [PATCH] [PM-22309] Resolve TypeScript 5.8 blockers for tool owned
 files (#16065)

* Add explicit return types to resolve typescript 5.8 blockers

* Remove type from input
---
 libs/common/src/tools/state/buffered-state.ts    | 16 +++++++++-------
 .../src/legacy-password-generation.service.ts    |  6 ++++--
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/libs/common/src/tools/state/buffered-state.ts b/libs/common/src/tools/state/buffered-state.ts
index b10ee6c7b85..c53390e4af7 100644
--- a/libs/common/src/tools/state/buffered-state.ts
+++ b/libs/common/src/tools/state/buffered-state.ts
@@ -45,12 +45,14 @@ export class BufferedState<Input, Output, Dependency> implements SingleUserState
       map((dependency) => [key.shouldOverwrite(dependency), dependency] as const),
     );
     const overwrite$ = combineLatest([hasValue$, overwriteDependency$]).pipe(
-      concatMap(async ([hasValue, [shouldOverwrite, dependency]]) => {
-        if (hasValue && shouldOverwrite) {
-          await this.overwriteOutput(dependency);
-        }
-        return [false, null] as const;
-      }),
+      concatMap(
+        async ([hasValue, [shouldOverwrite, dependency]]): Promise<readonly [false, null]> => {
+          if (hasValue && shouldOverwrite) {
+            await this.overwriteOutput(dependency);
+          }
+          return [false, null] as const;
+        },
+      ),
     );
 
     // drive overwrites only when there's a subscription;
@@ -71,7 +73,7 @@ export class BufferedState<Input, Output, Dependency> implements SingleUserState
   private async overwriteOutput(dependency: Dependency) {
     // take the latest value from the buffer
     let buffered: Input;
-    await this.bufferedState.update((state) => {
+    await this.bufferedState.update((state): Input | null => {
       buffered = state ?? null;
       return null;
     });
diff --git a/libs/tools/generator/extensions/legacy/src/legacy-password-generation.service.ts b/libs/tools/generator/extensions/legacy/src/legacy-password-generation.service.ts
index 41dcb94a001..02e86ad8fe0 100644
--- a/libs/tools/generator/extensions/legacy/src/legacy-password-generation.service.ts
+++ b/libs/tools/generator/extensions/legacy/src/legacy-password-generation.service.ts
@@ -345,7 +345,8 @@ export class LegacyPasswordGenerationService implements PasswordGenerationServic
       timeout({
         // timeout after 1 second
         each: 1000,
-        with() {
+        // TODO(PM-22309): Typescript 5.8 update, confirm type
+        with(): any[] {
           return [];
         },
       }),
@@ -370,7 +371,8 @@ export class LegacyPasswordGenerationService implements PasswordGenerationServic
       timeout({
         // timeout after 1 second
         each: 1000,
-        with() {
+        // TODO(PM-22309): Typescript 5.8 update, confirm type
+        with(): any[] {
           return [];
         },
       }),