From a5d045114c49ccf23d6bdeb7998cb4d48431414d Mon Sep 17 00:00:00 2001
From: Brandon Treston <btreston@bitwarden.com>
Date: Thu, 13 Feb 2025 16:35:52 -0500
Subject: [PATCH] [PM-18278] fix conditional in template (#13392)

* fix conditional in template

* update comment
---
 .../vault-header/vault-header.component.html  | 40 ++++++++++---------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/apps/web/src/app/vault/org-vault/vault-header/vault-header.component.html b/apps/web/src/app/vault/org-vault/vault-header/vault-header.component.html
index edba6e4753c..2c1e0077ac3 100644
--- a/apps/web/src/app/vault/org-vault/vault-header/vault-header.component.html
+++ b/apps/web/src/app/vault/org-vault/vault-header/vault-header.component.html
@@ -104,8 +104,8 @@
     *ngIf="filter.type !== 'trash' && filter.collectionId !== Unassigned && organization"
     class="tw-shrink-0"
   >
-    <!-- "New" menu is always shown unless the user cannot create a cipher -->
-    <ng-container *ngIf="canCreateCipher">
+    <!-- "New" menu is always shown unless the user cannot create a cipher and cannot create a collection-->
+    <ng-container *ngIf="canCreateCipher || canCreateCollection">
       <div appListDropdown>
         <button
           bitButton
@@ -119,24 +119,26 @@
           {{ "new" | i18n }}<i class="bwi tw-ml-2" aria-hidden="true"></i>
         </button>
         <bit-menu #addOptions aria-labelledby="newItemDropdown">
-          <button type="button" bitMenuItem (click)="addCipher(CipherType.Login)">
-            <i class="bwi bwi-globe" slot="start" aria-hidden="true"></i>
-            {{ "typeLogin" | i18n }}
-          </button>
-          <button type="button" bitMenuItem (click)="addCipher(CipherType.Card)">
-            <i class="bwi bwi-credit-card" slot="start" aria-hidden="true"></i>
-            {{ "typeCard" | i18n }}
-          </button>
-          <button type="button" bitMenuItem (click)="addCipher(CipherType.Identity)">
-            <i class="bwi bwi-id-card" slot="start" aria-hidden="true"></i>
-            {{ "typeIdentity" | i18n }}
-          </button>
-          <button type="button" bitMenuItem (click)="addCipher(CipherType.SecureNote)">
-            <i class="bwi bwi-sticky-note" slot="start" aria-hidden="true"></i>
-            {{ "note" | i18n }}
-          </button>
+          <ng-container *ngIf="canCreateCipher">
+            <button type="button" bitMenuItem (click)="addCipher(CipherType.Login)">
+              <i class="bwi bwi-globe" slot="start" aria-hidden="true"></i>
+              {{ "typeLogin" | i18n }}
+            </button>
+            <button type="button" bitMenuItem (click)="addCipher(CipherType.Card)">
+              <i class="bwi bwi-credit-card" slot="start" aria-hidden="true"></i>
+              {{ "typeCard" | i18n }}
+            </button>
+            <button type="button" bitMenuItem (click)="addCipher(CipherType.Identity)">
+              <i class="bwi bwi-id-card" slot="start" aria-hidden="true"></i>
+              {{ "typeIdentity" | i18n }}
+            </button>
+            <button type="button" bitMenuItem (click)="addCipher(CipherType.SecureNote)">
+              <i class="bwi bwi-sticky-note" slot="start" aria-hidden="true"></i>
+              {{ "note" | i18n }}
+            </button>
+          </ng-container>
           <ng-container *ngIf="canCreateCollection">
-            <bit-menu-divider></bit-menu-divider>
+            <bit-menu-divider *ngIf="canCreateCipher"></bit-menu-divider>
             <button type="button" bitMenuItem (click)="addCollection()">
               <i class="bwi bwi-fw bwi-collection" aria-hidden="true"></i>
               {{ "collection" | i18n }}