bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-21 03:43:58 +00:00
Code Issues Releases Wiki Activity

review and tidy code changes

Browse Source 
• remove unused logging methods in import.service.spec.ts
• restore (unused) feature flag support in generator-services.module.ts
• avoid type casting
• clarify doc comments
This commit is contained in:
John Harrington
2025-10-03 16:38:49 -07:00
parent 92d7521c66
commit a67aed3233
4 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/tools/generator/core/src/services/default-credential-generator.service.spec.ts
View File

@@ -55,7 +55,7 @@ describe("DefaultCredentialGeneratorService", () => {
}) as any;
logProvider = () => mockLogger;
mockExtension = { settings: jest.fn() } as any;
mockExtension = { settings: jest.fn() };
// Use a hard-coded value for mockAccount
account = {

4
libs/tools/generator/core/src/services/default-credential-generator.service.ts
View File

@@ -43,8 +43,8 @@ const THREE_MINUTES = 3 * 60 * 1000;
export class DefaultCredentialGeneratorService implements CredentialGeneratorService {
/** Instantiate the `DefaultCredentialGeneratorService`.
* @param provide application services required by the credential generator.
* @param extension extension service for managing forwarder extensions.
* @param log logger factory for creating semantic loggers.
* @param extension service for managing forwarder extensions.
* @param log factory for creating semantic loggers.
*/
constructor(
private readonly provide: CredentialGeneratorProviders,