bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 17:23:37 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Refactoring and organizing implementation

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-04-08 05:43:06 -05:00
parent bed24d17a9
commit a69d9d8f4a
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/autofill/background/abstractions/overlay.background.ts
View File

@@ -59,8 +59,8 @@ type OverlayBackgroundExtensionMessage = {
isFieldCurrentlyFilling?: boolean; isFieldCurrentlyFilling?: boolean;
subFrameData?: SubFrameOffsetData; subFrameData?: SubFrameOffsetData;
focusedFieldData?: FocusedFieldData; focusedFieldData?: FocusedFieldData;
data?: LockedVaultPendingNotificationsData;
styles?: Partial<CSSStyleDeclaration>; styles?: Partial<CSSStyleDeclaration>;
data?: LockedVaultPendingNotificationsData;
} & OverlayAddNewItemMessage; } & OverlayAddNewItemMessage;
type OverlayPortMessage = { type OverlayPortMessage = {

8
apps/browser/src/autofill/background/overlay.background.ts
View File

@@ -52,7 +52,7 @@ class OverlayBackground implements OverlayBackgroundInterface {
private overlayLoginCiphers: Map<string, CipherView> = new Map(); private overlayLoginCiphers: Map<string, CipherView> = new Map();
private pageDetailsForTab: PageDetailsForTab = {}; private pageDetailsForTab: PageDetailsForTab = {};
private subFrameOffsetsForTab: SubFrameOffsetsForTab = {}; private subFrameOffsetsForTab: SubFrameOffsetsForTab = {};
private rebuildSubFrameOffsetsTimeout: number | NodeJS.Timeout; private updateOverlayPositionAfterSubFrameRebuildTimeout: number | NodeJS.Timeout;
private userAuthStatus: AuthenticationStatus = AuthenticationStatus.LoggedOut; private userAuthStatus: AuthenticationStatus = AuthenticationStatus.LoggedOut;
private overlayButtonPort: chrome.runtime.Port; private overlayButtonPort: chrome.runtime.Port;
private overlayListPort: chrome.runtime.Port; private overlayListPort: chrome.runtime.Port;
@@ -306,8 +306,8 @@ class OverlayBackground implements OverlayBackgroundInterface {
return; return;
} }
if (this.rebuildSubFrameOffsetsTimeout) { if (this.updateOverlayPositionAfterSubFrameRebuildTimeout) {
clearTimeout(this.rebuildSubFrameOffsetsTimeout as number); clearTimeout(this.updateOverlayPositionAfterSubFrameRebuildTimeout);
} }
const frameTabs = Array.from(subFrameOffsetsForTab.keys()); const frameTabs = Array.from(subFrameOffsetsForTab.keys());
@@ -320,7 +320,7 @@ class OverlayBackground implements OverlayBackgroundInterface {
await this.buildSubFrameOffsets(sender.tab, frameId, sender.url); await this.buildSubFrameOffsets(sender.tab, frameId, sender.url);
} }
this.rebuildSubFrameOffsetsTimeout = setTimeout(() => { this.updateOverlayPositionAfterSubFrameRebuildTimeout = setTimeout(() => {
if (this.isFieldCurrentlyFocused) { if (this.isFieldCurrentlyFocused) {
void this.updateOverlayPosition({ overlayElement: AutofillOverlayElement.List }, sender); void this.updateOverlayPosition({ overlayElement: AutofillOverlayElement.List }, sender);
void this.updateOverlayPosition({ overlayElement: AutofillOverlayElement.Button }, sender); void this.updateOverlayPosition({ overlayElement: AutofillOverlayElement.Button }, sender);