From a7dabc45f1bc315aca2d998e8152d537ab1ad7bd Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Fri, 16 Aug 2019 17:11:45 -0400 Subject: [PATCH] fix safari browser test --- src/services/browserPlatformUtils.service.spec.ts | 5 +++++ src/services/browserPlatformUtils.service.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/services/browserPlatformUtils.service.spec.ts b/src/services/browserPlatformUtils.service.spec.ts index f2fa484a027..8a33f811d02 100644 --- a/src/services/browserPlatformUtils.service.spec.ts +++ b/src/services/browserPlatformUtils.service.spec.ts @@ -79,6 +79,11 @@ describe('Browser Utils Service', () => { const browserPlatformUtilsService = new BrowserPlatformUtilsService(null, null); expect(browserPlatformUtilsService.getDevice()).toBe(DeviceType.SafariExtension); + + Object.defineProperty(window, 'safariAppExtension', { + configurable: true, + value: false, + }); }); it('should detect vivaldi', () => { diff --git a/src/services/browserPlatformUtils.service.ts b/src/services/browserPlatformUtils.service.ts index 9da0fa529f6..8d8dfb45355 100644 --- a/src/services/browserPlatformUtils.service.ts +++ b/src/services/browserPlatformUtils.service.ts @@ -24,7 +24,7 @@ export default class BrowserPlatformUtilsService implements PlatformUtilsService return this.deviceCache; } - if (BrowserApi.isSafariApi) { + if ((window as any).safariAppExtension === true) { this.deviceCache = DeviceType.SafariExtension; } else if (navigator.userAgent.indexOf(' Firefox/') !== -1 || navigator.userAgent.indexOf(' Gecko/') !== -1) { this.deviceCache = DeviceType.FirefoxExtension;