From a885f65d716cd555caed22d1aa81fae920588e52 Mon Sep 17 00:00:00 2001 From: Jeffrey Holland Date: Wed, 3 Sep 2025 14:14:35 +0200 Subject: [PATCH] Revert `cipherId` param for `confirmNewCredential` --- .../autofill/services/desktop-fido2-user-interface.service.ts | 2 +- .../fido2/fido2-user-interface.service.abstraction.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts b/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts index 12182570670..8b64e448738 100644 --- a/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts +++ b/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts @@ -209,7 +209,7 @@ export class DesktopFido2UserInterfaceSession implements Fido2UserInterfaceSessi userHandle, userVerification, rpId, - }: NewCredentialParams): Promise<{ cipherId?: string; userVerified: boolean }> { + }: NewCredentialParams): Promise<{ cipherId: string; userVerified: boolean }> { this.logService.warning( "confirmNewCredential", credentialName, diff --git a/libs/common/src/platform/abstractions/fido2/fido2-user-interface.service.abstraction.ts b/libs/common/src/platform/abstractions/fido2/fido2-user-interface.service.abstraction.ts index b8be164c837..28b199da78f 100644 --- a/libs/common/src/platform/abstractions/fido2/fido2-user-interface.service.abstraction.ts +++ b/libs/common/src/platform/abstractions/fido2/fido2-user-interface.service.abstraction.ts @@ -95,7 +95,7 @@ export abstract class Fido2UserInterfaceSession { */ abstract confirmNewCredential( params: NewCredentialParams, - ): Promise<{ cipherId?: string; userVerified: boolean }>; + ): Promise<{ cipherId: string; userVerified: boolean }>; /** * Make sure that the vault is unlocked.