bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-02-20 11:24:07 +00:00
Code Issues Releases Wiki Activity

revert generate -> generator rename

Browse Source
This commit is contained in:
✨ Audrey ✨
2025-04-23 15:03:54 -04:00
parent e000fd77d4
commit a990419502
8 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/tools/generator/core/src/abstractions/credential-generator-service.abstraction.ts
View File

@@ -26,7 +26,7 @@ export abstract class CredentialGeneratorService {
/** Generates a stream of credentials
* @param dependencies.on$ Required. A new credential is emitted when this emits.
*/
abstract generator$: (
abstract generate$: (
dependencies: OnDependency<GenerateRequest> & BoundDependency<"account", Account>,
) => Observable<GeneratedCredential>;

4
libs/tools/generator/core/src/services/default-credential-generator.service.spec.ts
View File

@@ -112,7 +112,7 @@ describe("DefaultCredentialGeneratorService", () => {
account$: of(account),
};
const result = await firstValueFrom(service.generator$(dependencies));
const result = await firstValueFrom(service.generate$(dependencies));
expect(result).toBe("generatedPassword");
expect(providers.metadata!.metadata).toHaveBeenCalledWith("testAlgorithm");
@@ -141,7 +141,7 @@ describe("DefaultCredentialGeneratorService", () => {
account$: of(account),
};
const result = await firstValueFrom(service.generator$(dependencies));
const result = await firstValueFrom(service.generate$(dependencies));
expect(result).toBe("generatedPassword");
expect(providers.metadata!.metadata).toHaveBeenCalledWith("testAlgorithm");

2
libs/tools/generator/core/src/services/default-credential-generator.service.ts
View File

@@ -47,7 +47,7 @@ export class DefaultCredentialGeneratorService implements CredentialGeneratorSer
private readonly log: SemanticLogger;
generator$(dependencies: OnDependency<GenerateRequest> & BoundDependency<"account", Account>) {
generate$(dependencies: OnDependency<GenerateRequest> & BoundDependency<"account", Account>) {
// `on$` is partitioned into several streams so that the generator
// engine and settings refresh only when their respective inputs change
const on$ = dependencies.on$.pipe(shareReplay({ refCount: true, bufferSize: 1 }));