1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-13 06:43:35 +00:00

Defect/[PM-1887] - Fix Account Creation Terms of Service Checkbox not clickable in Safari (#5240)

* PM-1887 - Fix Account Creation Terms of service checkbox not clickable in Safari. Reworked check for breaches and terms of service checkboxes to be implemented with Tailwind instead of a mix of Tailwind & Bootstrap as well. Confirmed checkboxes still work in Edge, Firefiox, and Chrome as well as Safari now.

* PM-1887 - Add for="<id>" attributes to bit-labels for accessibility.

* PM-1887 - Make ID consistent w/ dashes instead of underlines and dashes.
This commit is contained in:
Jared Snider
2023-04-19 17:19:55 -04:00
committed by GitHub
parent 68b62e73f1
commit aa26bc5e17

View File

@@ -91,31 +91,27 @@
<div [hidden]="!showCaptcha()"> <div [hidden]="!showCaptcha()">
<iframe id="hcaptcha_iframe" height="80"></iframe> <iframe id="hcaptcha_iframe" height="80"></iframe>
</div> </div>
<div class="form-group"> <div class="tw-mb-4 tw-flex tw-items-start">
<div class="form-check"> <input
<input class="mt-1"
class="form-check-input" type="checkbox"
type="checkbox" bitCheckbox
id="checkForBreaches" id="checkForBreaches"
name="CheckBreach" name="CheckBreach"
formControlName="checkForBreaches" formControlName="checkForBreaches"
/> />
<label class="form-check-label" for="checkForBreaches"> <bit-label for="checkForBreaches"> {{ "checkForBreaches" | i18n }}</bit-label>
{{ "checkForBreaches" | i18n }}
</label>
</div>
</div> </div>
<div class="tw-mb-3 tw-flex tw-items-start" *ngIf="showTerms"> <div class="tw-mb-3 tw-flex tw-items-start" *ngIf="showTerms">
<div class="tw-flex tw-h-6 tw-items-center"> <input
<input class="mt-1"
id="register-form_input_accept-policies" id="register-form-input-accept-policies"
class="tw-border-gray-300 tw-w-4 tw-rounded tw-border" bitCheckbox
bitInput type="checkbox"
type="checkbox" formControlName="acceptPolicies"
formControlName="acceptPolicies" />
/>
</div> <bit-label for="register-form-input-accept-policies">
<bit-label class="ml-2">
{{ "acceptPolicies" | i18n }}<br /> {{ "acceptPolicies" | i18n }}<br />
<a href="https://bitwarden.com/terms/" target="_blank" rel="noopener">{{ <a href="https://bitwarden.com/terms/" target="_blank" rel="noopener">{{
"termsOfService" | i18n "termsOfService" | i18n