From aa642675730dea495fb50c0a3e7ae221d70399ce Mon Sep 17 00:00:00 2001 From: rr-bw <102181210+rr-bw@users.noreply.github.com> Date: Wed, 14 May 2025 03:13:48 -0700 Subject: [PATCH] [Account Recovery][PM-18721] convert enum to as const --- .../account-recovery-dialog.component.ts | 15 +++++++++------ .../organizations/members/members.component.ts | 4 ++-- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/apps/web/src/app/admin-console/organizations/members/components/account-recovery/account-recovery-dialog.component.ts b/apps/web/src/app/admin-console/organizations/members/components/account-recovery/account-recovery-dialog.component.ts index bc0daeee7c3..b01e142ffc0 100644 --- a/apps/web/src/app/admin-console/organizations/members/components/account-recovery/account-recovery-dialog.component.ts +++ b/apps/web/src/app/admin-console/organizations/members/components/account-recovery/account-recovery-dialog.component.ts @@ -52,9 +52,12 @@ export type AccountRecoveryDialogData = { organizationId: string; }; -export enum AccountRecoveryDialogResult { - Ok = "ok", -} +export const AccountRecoveryDialogResultTypes = { + Ok: "ok", +} as const; + +type AccountRecoveryDialogResultType = + (typeof AccountRecoveryDialogResultTypes)[keyof typeof AccountRecoveryDialogResultTypes]; /** * Used in a dialog for initiating the account recovery process against a @@ -81,7 +84,7 @@ export class AccountRecoveryDialogComponent implements OnInit { constructor( @Inject(DIALOG_DATA) protected dialogData: AccountRecoveryDialogData, private accountService: AccountService, - private dialogRef: DialogRef, + private dialogRef: DialogRef, private i18nService: I18nService, private logService: LogService, private policyService: PolicyService, @@ -119,7 +122,7 @@ export class AccountRecoveryDialogComponent implements OnInit { this.logService.error(e); } - this.dialogRef.close(AccountRecoveryDialogResult.Ok); + this.dialogRef.close(AccountRecoveryDialogResultTypes.Ok); } /** @@ -131,7 +134,7 @@ export class AccountRecoveryDialogComponent implements OnInit { dialogService: DialogService, dialogConfig: DialogConfig, ) => { - return dialogService.open( + return dialogService.open( AccountRecoveryDialogComponent, dialogConfig, ); diff --git a/apps/web/src/app/admin-console/organizations/members/members.component.ts b/apps/web/src/app/admin-console/organizations/members/members.component.ts index 6bc86d5e72a..bf76859719a 100644 --- a/apps/web/src/app/admin-console/organizations/members/members.component.ts +++ b/apps/web/src/app/admin-console/organizations/members/members.component.ts @@ -68,7 +68,7 @@ import { openEntityEventsDialog } from "../manage/entity-events.component"; import { AccountRecoveryDialogComponent, - AccountRecoveryDialogResult, + AccountRecoveryDialogResultTypes, } from "./components/account-recovery/account-recovery-dialog.component"; import { BulkConfirmDialogComponent } from "./components/bulk/bulk-confirm-dialog.component"; import { BulkDeleteDialogComponent } from "./components/bulk/bulk-delete-dialog.component"; @@ -757,7 +757,7 @@ export class MembersComponent extends BaseMembersComponent }); const result = await lastValueFrom(dialogRef.closed); - if (result === AccountRecoveryDialogResult.Ok) { + if (result === AccountRecoveryDialogResultTypes.Ok) { await this.load(); } } else {