bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-20 02:03:39 +00:00
Code Issues Releases Wiki Activity

Address review feedback on UnassignedBannerService (#8680)

Browse Source 
* Introduce `UnassignedItemsBannerApiService`

* Delete `WebUnassignedItemsBannerService`
This commit is contained in:
Addison Beck
2024-04-10 16:13:41 -05:00
committed by GitHub
parent 98ed744ae8
commit ab83a367dd
9 changed files with 28 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/web/src/app/layouts/header/web-header.component.ts
View File

@@ -2,6 +2,7 @@ import { Component, Input } from "@angular/core";
import { ActivatedRoute } from "@angular/router";
import { combineLatest, map, Observable } from "rxjs";
import { UnassignedItemsBannerService } from "@bitwarden/angular/services/unassigned-items-banner.service";
import { VaultTimeoutSettingsService } from "@bitwarden/common/abstractions/vault-timeout/vault-timeout-settings.service";
import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
import { VaultTimeoutAction } from "@bitwarden/common/enums/vault-timeout-action.enum";
@@ -11,8 +12,6 @@ import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/pl
import { StateService } from "@bitwarden/common/platform/abstractions/state.service";
import { AccountProfile } from "@bitwarden/common/platform/models/domain/account";
import { WebUnassignedItemsBannerService } from "./web-unassigned-items-banner.service";
@Component({
selector: "app-header",
templateUrl: "./web-header.component.html",
@@ -43,7 +42,7 @@ export class WebHeaderComponent {
private platformUtilsService: PlatformUtilsService,
private vaultTimeoutSettingsService: VaultTimeoutSettingsService,
private messagingService: MessagingService,
protected webUnassignedItemsBannerService: WebUnassignedItemsBannerService,
protected unassignedItemsBannerService: UnassignedItemsBannerService,
private configService: ConfigService,
) {
this.routeData$ = this.route.data.pipe(