bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

Address review feedback on UnassignedBannerService (#8680)

Browse Source 
* Introduce `UnassignedItemsBannerApiService`

* Delete `WebUnassignedItemsBannerService`
This commit is contained in:
Addison Beck
2024-04-10 16:13:41 -05:00
committed by GitHub
parent 98ed744ae8
commit ab83a367dd
9 changed files with 28 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libs/common/src/abstractions/api.service.ts
View File

@@ -207,7 +207,6 @@ export abstract class ApiService {
emergencyAccessId?: string,
) => Promise<AttachmentResponse>;
getCiphersOrganization: (organizationId: string) => Promise<ListResponse<CipherResponse>>;
getShowUnassignedCiphersBanner: () => Promise<boolean>;
postCipher: (request: CipherRequest) => Promise<CipherResponse>;
postCipherCreate: (request: CipherCreateRequest) => Promise<CipherResponse>;
postCipherAdmin: (request: CipherCreateRequest) => Promise<CipherResponse>;

5
libs/common/src/services/api.service.ts
View File

@@ -506,11 +506,6 @@ export class ApiService implements ApiServiceAbstraction {
return new ListResponse(r, CipherResponse);
}
async getShowUnassignedCiphersBanner(): Promise<boolean> {
const r = await this.send("GET", "/ciphers/has-unassigned-ciphers", null, true, true);
return r;
}
async postCipher(request: CipherRequest): Promise<CipherResponse> {
const r = await this.send("POST", "/ciphers", request, true, true);
return new CipherResponse(r);