bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

Platform - Prefer signal & change detection (#16946)

Browse Source
This commit is contained in:
Oscar Hinton
2025-10-27 15:13:17 +01:00
committed by GitHub
parent 942f403ed0
commit abc6e54bb9
8 changed files with 42 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/platform/popup/components/pop-out.component.ts
View File

@@ -7,12 +7,16 @@ import { IconButtonModule } from "@bitwarden/components";
import BrowserPopupUtils from "../../browser/browser-popup-utils";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-pop-out",
templateUrl: "pop-out.component.html",
imports: [CommonModule, JslibModule, IconButtonModule],
})
export class PopOutComponent implements OnInit {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() show = true;
constructor(private platformUtilsService: PlatformUtilsService) {}

2
apps/browser/src/platform/popup/view-cache/popup-router-cache.spec.ts
View File

@@ -13,6 +13,8 @@ import { PopupRouterCacheService, popupRouterCacheGuard } from "./popup-router-c
const flushPromises = async () => await new Promise(process.nextTick);
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
template: "",
standalone: false,

4
apps/browser/src/platform/popup/view-cache/popup-view-cache.spec.ts
View File

@@ -19,12 +19,16 @@ import {
import { PopupViewCacheService } from "./popup-view-cache.service";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
template: "",
standalone: false,
})
export class EmptyComponent {}
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
template: "",
standalone: false,