bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 13:53:34 +00:00
Code Issues Releases Wiki Activity

Platform - Prefer signal & change detection (#16946)

Browse Source
This commit is contained in:
Oscar Hinton
2025-10-27 15:13:17 +01:00
committed by GitHub
parent 942f403ed0
commit abc6e54bb9
8 changed files with 42 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.ts
View File

@@ -6,14 +6,22 @@ import { KeyService } from "@bitwarden/key-management";
import { SharedModule } from "../../shared.module";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-account-fingerprint",
templateUrl: "account-fingerprint.component.html",
imports: [SharedModule],
})
export class AccountFingerprintComponent implements OnInit {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() fingerprintMaterial: string;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() publicKeyBuffer: Uint8Array;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() fingerprintLabel: string;
protected fingerprint: string;

12
apps/web/src/app/shared/components/onboarding/onboarding-task.component.ts
View File

@@ -2,6 +2,8 @@
// @ts-strict-ignore
import { Component, Input } from "@angular/core";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-onboarding-task",
templateUrl: "./onboarding-task.component.html",
@@ -11,18 +13,28 @@ import { Component, Input } from "@angular/core";
standalone: false,
})
export class OnboardingTaskComponent {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input()
completed = false;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input()
icon = "bwi-info-circle";
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input()
title: string;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input()
route: string | any[];
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input()
isDisabled: boolean = false;

8
apps/web/src/app/shared/components/onboarding/onboarding.component.ts
View File

@@ -4,15 +4,23 @@ import { Component, ContentChildren, EventEmitter, Input, Output, QueryList } fr
import { OnboardingTaskComponent } from "./onboarding-task.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({
selector: "app-onboarding",
templateUrl: "./onboarding.component.html",
standalone: false,
})
export class OnboardingComponent {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@ContentChildren(OnboardingTaskComponent) tasks: QueryList<OnboardingTaskComponent>;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() title: string;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-output-emitter-ref
@Output() dismiss = new EventEmitter<void>();
protected open = true;