From 3e9fb2009ebb252182af08b369e4828cb441bf59 Mon Sep 17 00:00:00 2001 From: Nick Krantz <125900171+nick-livefront@users.noreply.github.com> Date: Wed, 4 Sep 2024 10:50:34 -0500 Subject: [PATCH 01/28] [PM-10934] Remove last form-field bottom border (#10751) * match API of new CL FormField component * remove readonly border for additional options component * remove readonly border for last autofill option * remove readonly border for last custom-field form field * remove readonly border for when collection,org or folder is available * add `ReadOnlyCipherCardComponent` to handle readonly border * remove readonly border for the last identity form field * remove readonly border for the last card form field * remove readonly border for the last login form field * remove unneeded true value --- .../src/form-field/form-field.component.ts | 8 ++++++ .../additional-options.component.html | 2 +- .../autofill-options-view.component.html | 6 ++++- .../card-details-view.component.html | 4 +-- .../card-details-view.component.ts | 3 +++ .../custom-fields-v2.component.html | 6 ++--- .../item-details-v2.component.html | 3 +++ .../login-credentials-view.component.html | 4 +-- .../login-credentials-view.component.ts | 2 ++ .../read-only-cipher-card.component.html | 3 +++ .../read-only-cipher-card.component.ts | 26 +++++++++++++++++++ .../view-identity-sections.component.html | 12 ++++----- .../view-identity-sections.component.ts | 3 +++ 13 files changed, 67 insertions(+), 15 deletions(-) create mode 100644 libs/vault/src/cipher-view/read-only-cipher-card/read-only-cipher-card.component.html create mode 100644 libs/vault/src/cipher-view/read-only-cipher-card/read-only-cipher-card.component.ts diff --git a/libs/components/src/form-field/form-field.component.ts b/libs/components/src/form-field/form-field.component.ts index 6fcb4090ddd..1e364115a6f 100644 --- a/libs/components/src/form-field/form-field.component.ts +++ b/libs/components/src/form-field/form-field.component.ts @@ -1,6 +1,7 @@ import { coerceBooleanProperty } from "@angular/cdk/coercion"; import { AfterContentChecked, + booleanAttribute, Component, ContentChild, ContentChildren, @@ -38,6 +39,13 @@ export class BitFormFieldComponent implements AfterContentChecked { return this._disableMargin; } + /** + * NOTE: Placeholder to match the API of the form-field component in the `ps/extension` branch, + * no functionality is implemented as of now. + */ + @Input({ transform: booleanAttribute }) + disableReadOnlyBorder = false; + @HostBinding("class") get classList() { return ["tw-block"].concat(this.disableMargin ? [] : ["tw-mb-6"]); diff --git a/libs/vault/src/cipher-view/additional-options/additional-options.component.html b/libs/vault/src/cipher-view/additional-options/additional-options.component.html index 6f254b8c729..0913629ad9e 100644 --- a/libs/vault/src/cipher-view/additional-options/additional-options.component.html +++ b/libs/vault/src/cipher-view/additional-options/additional-options.component.html @@ -3,7 +3,7 @@
+ {{ subtitleText | i18n }} +
+ +{{ "passkeyAlreadyExists" | i18n }}
+{{ "noPasskeysFoundForThisApplication" | i18n }}
+{{ "passkeyAlreadyExists" | i18n }}
+- {{ subtitleText | i18n }} -
- -{{ "passkeyAlreadyExists" | i18n }}
-{{ "noPasskeysFoundForThisApplication" | i18n }}
-{{ "noPasskeysFoundForThisApplication" | i18n }}
+